Build hyperkube in hack/local-up-cluster instead of separate binaries #25627
+20
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parate binaries. Also add arm64 as a valid arch
|
This isn't covered by e2e |
k8s-github-robot
added
size/M
luxas
added
release-note-none
|
GCE e2e build/test passed for commit 8e64b5f. |
|
Part of the purpose of hack/local-up-cluster is to validate that the individual components start cleanly (i.e., to test cmd/kube-apiserver/... in isolation). I wouldn't necessarily expect us to make this change until we were adding hyperkube to the core setup. |
|
Okay, understand that. |
|
On the other hand, the only place local up is used is to assist local development, and if hyperkube is faster then I think that's more important. E2e probably covers the other entry point sufficiently. So I think this is a net win. |
smarterclayton
added
the
lgtm
|
Maybe we should add a release note for this so people notice that it has changed? |
smarterclayton
added
release-note
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the build time a lot.
Also add arm64 as a valid arch
This is quite trivial. Let's get it in asap
@thockin @pmorie @liggitt @eparis @zmerlynn @smarterclayton