Make multivalued requirement parser more whitespace tolerant #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Great, thanks. Sorry for the delay. LGTM. |
bgrant0607
added a commit
that referenced
this pull request
Dec 8, 2014
…tivalued-requirement-parser Make multivalued requirement parser more whitespace tolerant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few areas to the syntax where more whitespace is allowed:
a. before key - i.e. " x"
b. after key for in/not in cases - i.e. "x HERE in (foo)"
c. between "not" and "in" for not in case - i.e. "x not HERE in (foo)"
b. between "in" and value set for in/not in cases - i.e. "x in HERE (foo)" "x not in HERE (foo)"
There are still some areas left so this PR is a start:
a. in the values set - i.e. "x in ( a , b )"
b. after key for exists case - i.e. "x "
c. after end of values set - i.e. "x in (c) "