Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitHostPort is needed since Request.RemoteAddr has the host:port format #25501

Merged
merged 1 commit into from
May 22, 2016
Merged

SplitHostPort is needed since Request.RemoteAddr has the host:port format #25501

merged 1 commit into from
May 22, 2016

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented May 11, 2016

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2016
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 11, 2016
@bgrant0607 bgrant0607 assigned ncdc and unassigned bgrant0607 May 11, 2016
@bgrant0607 bgrant0607 added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 11, 2016
@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2016
@bprashanth
Copy link
Contributor

failure seems legit

Call stack:
  1: ./hack/../hack/verify-api-reference-docs.sh:34 main(...)
Exiting with status 1
FAILED   ./hack/../hack/verify-api-reference-docs.sh    1s
Verifying ./hack/../hack/verify-boilerplate.sh
SUCCESS  ./hack/../hack/verify-boilerplate.sh   0s

@bprashanth
Copy link
Contributor

@k8s-bot unit test this issue #IGNORE (docker in docker 1.11 weirdness - kubernetes/test-infra#47)

@bprashanth
Copy link
Contributor

@k8s-bot unit test this issue #IGNORE

@soltysh
Copy link
Contributor Author

soltysh commented May 16, 2016

@k8s-bot test this github flake: #22655

5 similar comments
@soltysh
Copy link
Contributor Author

soltysh commented May 16, 2016

@k8s-bot test this github flake: #22655

@soltysh
Copy link
Contributor Author

soltysh commented May 16, 2016

@k8s-bot test this github flake: #22655

@soltysh
Copy link
Contributor Author

soltysh commented May 16, 2016

@k8s-bot test this github flake: #22655

@ArtfulCoder
Copy link
Contributor

@k8s-bot test this github flake: #22655

@soltysh
Copy link
Contributor Author

soltysh commented May 17, 2016

@k8s-bot test this github flake: #22655

@k8s-bot
Copy link

k8s-bot commented May 22, 2016

GCE e2e build/test passed for commit b77356a.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 94c7e94 into kubernetes:master May 22, 2016
@soltysh soltysh deleted the net_remoteaddr branch May 23, 2016 06:44
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Nov 6, 2020
@k8s-publishing-bot
Merge pull request kubernetes#25501 from wgahnagl/symlink-cherry-pick
a9cc6d5 
Bug 1878795: UPSTREAM: 89160 Only Remove unhealthy symlink for dead containers

Origin-commit: 99078c83e78e273b74c97ee6eaec3ace218f8ae4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@soltysh @bprashanth @ArtfulCoder @k8s-bot @k8s-github-robot @ncdc @smarterclayton @googlebot @bgrant0607