Add command "kubectl config get-contexts" #25463

asalkeld · 2016-05-11T10:58:15Z

* A new command "kubectl config get-contexts" has been added.

fixes #25383

k8s-bot · 2016-05-11T10:58:34Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-05-11T10:59:12Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-05-11T11:00:12Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

bgrant0607 · 2016-05-11T14:27:42Z

pkg/kubectl/cmd/config/list_context_test.go

+			"shaker-context":     {AuthInfo: "green-user", Cluster: "horse-cluster", Namespace: "chisel-ns"}}}
+	test := listContextTest{
+		startingConfig: tconfig,
+		expectedOut:    "queen-anne-context\nshaker-context\n",


Please ensure that the contexts are sorted in a deterministic order.

It would also be useful to see the context properties (AuthInfo, Cluster, Namespace), in columnar form.

bgrant0607 · 2016-05-11T14:53:36Z

pkg/kubectl/cmd/config/list_context.go

+
+	cmd := &cobra.Command{
+		Use:   "list-context",
+		Short: "List the current-contexts",


It's all contexts not just the current-context

deads2k · 2016-05-11T14:57:19Z

@bgrant0607 This would be another command that is "different" as noted in #20605. Just want to make sure you're ok with another one before we go too far down this path.

bgrant0607 · 2016-05-11T14:58:55Z

pkg/kubectl/cmd/config/list_context.go

+	options := &ListContextOptions{configAccess: configAccess}
+
+	cmd := &cobra.Command{
+		Use:   "list-context",


Please call it get-context. list is not an ordinary kubectl command, but get is.

kubectl get-context should print all contexts.

kubectl get-context <context-name> should print just the selected context.

kubectl get-context -o name should print the names of all contexts.

bgrant0607 · 2016-05-11T15:00:47Z

@deads2k I'm ok with it, though we should try to make it as similar to other commands as we can, hence my comments about get vs. list, columnar output, etc.

At some point, we'll need to redo the whole command group.

asalkeld · 2016-05-11T23:32:34Z

Thanks for the review @bgrant0607 and @deads2k, I'll re-work this to better fit in.

asalkeld · 2016-05-18T01:57:08Z

Please let me know if I should squash these commits, there is a lot of renaming going on.

deads2k · 2016-05-18T14:37:15Z

pkg/kubectl/cmd/config/get_context.go

@@ -0,0 +1,169 @@
+/*
+Copyright 2014 The Kubernetes Authors All rights reserved.


k8s-bot · 2016-06-18T23:00:20Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-20T23:42:18Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-21T00:33:33Z

GCE e2e build/test passed for commit f40ba00414124b254c337f6815304a7079b56e7b.

asalkeld · 2016-06-28T09:42:18Z

Rebased and @deads2k it now includes "git branch" style *

$ kubectl config get-contexts
CURRENT   NAME      CLUSTER   AUTHINFO   NAMESPACE
          fluffy    local     bear       
*         local     local                
$ kubectl config get-contexts -o name
  fluffy
* local

k8s-bot · 2016-06-28T10:20:43Z

GCE e2e build/test passed for commit 2a9e3ab98a898644fca1dfefd6b886b66586c7c1.

deads2k · 2016-06-28T11:33:06Z

Rebased and @deads2k it now includes "git branch" style *

Sorry, can't do that with -o name. That flag is intended for scripts and a * in the output could cause them trouble.

asalkeld · 2016-06-28T13:06:23Z

ok, i'll remove it out of -o name.

k8s-bot · 2016-06-28T13:53:52Z

GCE e2e build/test passed for commit 63ef43428a843068d0963a98774bbfb64108ca25.

deads2k · 2016-06-29T15:57:09Z

CI says

FAILED ./hack/../hack/verify-generated-docs.sh 148s

asalkeld · 2016-07-04T10:41:35Z

rebased, and fixed the generated docs failure..

k8s-bot · 2016-07-04T11:20:48Z

GCE e2e build/test passed for commit b0632847c72f0eb5fc17f40ba8bfa089b6a69bdd.

Note: Context is not a runtime object (doesn't have Kind and Version) so we can't use the resource_printer

k8s-bot · 2016-07-05T10:04:10Z

GCE e2e build/test passed for commit e0ce987.

k8s-github-robot · 2016-07-05T12:00:09Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-07-05T12:32:54Z

GCE e2e build/test passed for commit e0ce987.

k8s-github-robot · 2016-07-05T12:33:23Z

Automatic merge from submit-queue

…ation [release-3.11] Bug 1760807: Update pod affinity check in priority for valid labels Origin-commit: 1948f11155e97fe3f115c0beb4bae800f41bd2e2

googlebot added the cla: yes label May 11, 2016

k8s-github-robot assigned bgrant0607 May 11, 2016

k8s-github-robot added kind/old-docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2016

bgrant0607 reviewed May 11, 2016
View reviewed changes

bgrant0607 assigned deads2k and unassigned bgrant0607 May 11, 2016

bgrant0607 reviewed May 11, 2016
View reviewed changes

k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2016

deads2k reviewed May 18, 2016
View reviewed changes

pkg/kubectl/cmd/config/get_context.go

@@ -0,0 +1,169 @@

/*

Copyright 2014 The Kubernetes Authors All rights reserved.

Copy link

Contributor

deads2k May 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2016

asalkeld force-pushed the master branch from f40ba00 to 2a9e3ab Compare June 28, 2016 09:39

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 28, 2016

asalkeld force-pushed the master branch from 2a9e3ab to 63ef434 Compare June 28, 2016 13:20

deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2016

asalkeld force-pushed the master branch from 63ef434 to b063284 Compare July 4, 2016 10:41

k8s-github-robot added kind/old-docs and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 4, 2016

Add command "kubectl config get-contexts"

e0ce987

Note: Context is not a runtime object (doesn't have Kind and Version) so we can't use the resource_printer

asalkeld force-pushed the master branch from b063284 to e0ce987 Compare July 5, 2016 09:27

deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2016

k8s-github-robot merged commit a75cb46 into kubernetes:master Jul 5, 2016

deads2k mentioned this pull request Aug 1, 2016

Kubectl delete-cluster, list-clusters, delete-contexts, list-contexts #29794

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add command "kubectl config get-contexts" #25463

Add command "kubectl config get-contexts" #25463

asalkeld commented May 11, 2016 •

edited by janetkuo

Loading

k8s-bot commented May 11, 2016

k8s-bot commented May 11, 2016

k8s-bot commented May 11, 2016

bgrant0607 May 11, 2016

bgrant0607 May 11, 2016

bgrant0607 May 11, 2016

deads2k commented May 11, 2016

bgrant0607 May 11, 2016

bgrant0607 commented May 11, 2016

asalkeld commented May 11, 2016

asalkeld commented May 18, 2016

deads2k May 18, 2016

k8s-bot commented Jun 18, 2016

k8s-bot commented Jun 20, 2016

k8s-bot commented Jun 21, 2016

asalkeld commented Jun 28, 2016

k8s-bot commented Jun 28, 2016

deads2k commented Jun 28, 2016

asalkeld commented Jun 28, 2016

k8s-bot commented Jun 28, 2016

deads2k commented Jun 29, 2016

asalkeld commented Jul 4, 2016

k8s-bot commented Jul 4, 2016

k8s-bot commented Jul 5, 2016

k8s-github-robot commented Jul 5, 2016

k8s-bot commented Jul 5, 2016

k8s-github-robot commented Jul 5, 2016

		@@ -0,0 +1,169 @@
		/*
		Copyright 2014 The Kubernetes Authors All rights reserved.

Add command "kubectl config get-contexts" #25463

Add command "kubectl config get-contexts" #25463

Conversation

asalkeld commented May 11, 2016 • edited by janetkuo Loading

k8s-bot commented May 11, 2016

k8s-bot commented May 11, 2016

k8s-bot commented May 11, 2016

bgrant0607 May 11, 2016

Choose a reason for hiding this comment

bgrant0607 May 11, 2016

Choose a reason for hiding this comment

bgrant0607 May 11, 2016

Choose a reason for hiding this comment

deads2k commented May 11, 2016

bgrant0607 May 11, 2016

Choose a reason for hiding this comment

bgrant0607 commented May 11, 2016

asalkeld commented May 11, 2016

asalkeld commented May 18, 2016

deads2k May 18, 2016

Choose a reason for hiding this comment

k8s-bot commented Jun 18, 2016

k8s-bot commented Jun 20, 2016

k8s-bot commented Jun 21, 2016

asalkeld commented Jun 28, 2016

k8s-bot commented Jun 28, 2016

deads2k commented Jun 28, 2016

asalkeld commented Jun 28, 2016

k8s-bot commented Jun 28, 2016

deads2k commented Jun 29, 2016

asalkeld commented Jul 4, 2016

k8s-bot commented Jul 4, 2016

k8s-bot commented Jul 5, 2016

k8s-github-robot commented Jul 5, 2016

k8s-bot commented Jul 5, 2016

k8s-github-robot commented Jul 5, 2016

asalkeld commented May 11, 2016 •

edited by janetkuo

Loading