GKE provider: Add cluster-ipv4-cidr and arbitrary flags #25437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerlynn
added
area/test-infra
release-note
zmerlynn
added
the
priority/backlog
k8s-github-robot
added
the
size/S
roberthbailey
added
the
lgtm
zmerlynn
added a commit
to zmerlynn/test-infra
that referenced
this pull request
May 10, 2016
Relies on kubernetes/kubernetes#25437, but this suite is manual, so I'll make sure that's merged before I kick this one again.
| create_args+=("--cluster-ipv4-cidr=${CLUSTER_IP_RANGE}") | ||
| fi | ||
|
|
||
| create_args+=( ${GKE_CREATE_FLAGS:-} ) |
There was a problem hiding this comment.
Can you explain why we don't want to put ${GKE_CREATE_FLAGS:-} in quotes?
There was a problem hiding this comment.
It's intentional - it implicitly splits across spaces and dumps it in the array, e.g.:
$ LIST="foo bar blat"
$ ARR=( ${LIST} )
$ echo ${ARR[2]}
blat
There was a problem hiding this comment.
Thanks! I figured it was intentional, just wanted a free bash lesson from you :)
|
LGTM |
|
GCE e2e build/test passed for commit e42f201. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @roberthbailey @a-robinson @cjcullen
This change is