Add GoRoutineMap.Wait method. #25399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful for testing - code under tests creates an operation and my test needs to wait until the operation finishes before evaluating results.
jsafrane
added
release-note-none
|
@saad-ali, PTAL |
k8s-github-robot
added
the
size/M
| @@ -73,4 +80,9 @@ func (grm *goRoutineMap) operationComplete(operationName string) { | |||
| grm.Lock() | |||
| defer grm.Unlock() | |||
| delete(grm.operations, operationName) | |||
| grm.wg.Done() | |||
There was a problem hiding this comment.
Done() should be called with defer. Defer statements are executed in stack order (last in, first executed), so make sure defer grm.wg.Done() is called after defer grm.Unlock().
jsafrane
force-pushed
the
devel/wait-for-operation
branch
from
f70d61f to
6623385
Compare
|
Fixed review remarks and pushed. Thanks for the review! |
|
GCE e2e build/test passed for commit 6623385. |
saad-ali
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful for testing - code under tests creates an operation and the test needs to wait until the operation finishes before evaluating results.