Enable docker registry cache. By default it is off #2537
Merged
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,17 @@ grains: | |||
| cloud: gce | |||
| EOF | |||
|
|
|||
| # Decide if enable the cache | |||
There was a problem hiding this comment.
Might want to add a comment indicating that this is a GCE/GKE only feature... or is that implied?
There was a problem hiding this comment.
It is implied since only gce util.sh will generate salt-minion script with ENABLE_DOCKER_REGISTRY_CACHE varible. Also by default, it is false on omit.
|
LGTM. We might want to add a comment or two indicating that this will only work for GCE/GKE customers, and that it's alpha, etc. |
|
LGTM |
thockin
added a commit
that referenced
this pull request
Nov 24, 2014
Enable docker registry cache. By default it is off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it in my cluster, and saw overall performance improvement over time.
@timbot @brendandburns @thockin