-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local disk for ConfigMap volume instead of tmpfs #25306
Conversation
configmaps were GA in 1.2, right? So should this be marked as release-note-action-needed since it's a behavioral change to a GA API? |
I think it is a release note, but not action required. It will change the behavior but not in any way that most users will really notice. But @pmorie why? ConfigMap objects are already limited by API object size (1 MB today, unlikely to grow beyond O(tens) of MB). Does that memory cost and disk accounting matter? tmpfs has some really nice properties wrt performance... |
The memory consumed is charged to the Kubelet and not the pod cgroup. If On Sunday, May 8, 2016, Kubernetes Bot notifications@github.com wrote:
|
Ahh, of course. We know how to fix that, but we have to get a patch into Can we leave a TODO here saying it probably should be tmpfs, but it needs
|
@thockin Should config maps be stored in tmpfs at all? Why do you think config maps demand high performance storage? |
Thanks for the fix @pmorie ! |
We do work on the behalf of users. Once we get disk io limiting, we will But I argue tmpfs not for perf but for deterministic behavior.
|
So that ConfigMap volumes are counted against pod's storage quota.
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3567b1f. |
Automatic merge from submit-queue |
So that ConfigMap volumes are counted against pod's storage quota.
@kubernetes/sig-node
cc @derekwaynecarr @vishh