Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kubectl describe test from flaky list #25291

Merged
merged 1 commit into from
May 30, 2016
Merged

Remove kubectl describe test from flaky list #25291

merged 1 commit into from
May 30, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented May 6, 2016 •
edited
Loading

Pull Request Guidelines

  1. Please read our contributor guidelines.
  2. See our developer guide.
  3. Follow the instructions for labeling and writing a release note for this PR in the block below.
* Use the release-note-* labels to set the release note state 
* Clear this block to use the PR title as the release note 
-OR-
* Enter your extended release note here

Ref #25083 #25911

Analytics

@janetkuo janetkuo added area/test release-note-none Denotes a PR that doesn't merit a release note. labels May 6, 2016
@janetkuo janetkuo mentioned this pull request May 6, 2016
Closed
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2016
@spxtr
Copy link
Contributor

spxtr commented May 7, 2016

It flaked several times after #24849 went in.

@spxtr
Copy link
Contributor

spxtr commented May 16, 2016

It's broken: #25677

@spxtr
Copy link
Contributor

spxtr commented May 17, 2016

Please reassign when the test is fixed.

@spxtr spxtr assigned janetkuo and unassigned spxtr May 17, 2016
@janetkuo janetkuo assigned spxtr and unassigned janetkuo May 18, 2016
@janetkuo
Copy link
Member Author

It looks pretty green now.
https://gke-testdash.corp.google.com/#gce-flaky&width=5
https://gke-testdash.corp.google.com/#gke-flaky&width=5

Will watch it to see if it's still flaky

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2016
@janetkuo janetkuo force-pushed the describe-rc-pods-non-flake branch from 09f85a7 to 6ca3c16 Compare May 19, 2016 04:27
@janetkuo janetkuo removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2016
@janetkuo
Copy link
Member Author

@k8s-bot e2e test this issue: #25887

@janetkuo janetkuo assigned janetkuo and unassigned spxtr May 20, 2016
@janetkuo
Copy link
Member Author

#25784 #26122 should fix this issue. No flakes observed on gce-flaky or gke-flaky since 23rd. Ref #25911

@janetkuo janetkuo assigned spxtr and unassigned janetkuo May 26, 2016
@spxtr
Copy link
Contributor

spxtr commented May 26, 2016

Ok.

@spxtr spxtr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2016
@wojtek-t wojtek-t added this to the v1.3 milestone May 30, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 30, 2016

GCE e2e build/test passed for commit 6ca3c16.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a9f96da into kubernetes:master May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

Labels
area/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@janetkuo @spxtr @k8s-github-robot @k8s-bot @googlebot @wojtek-t