kubectl run --restart=Never creates pods #25253
Merged
+46
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
kind/old-docs
size/S
|
Silly me forgot about updating e2e tests, should be ok. |
k8s-github-robot
added
size/M
k8s-github-robot
added
the
needs-rebase
k8s-github-robot
removed
the
needs-rebase
|
Rebased, @janetkuo ptal. |
janetkuo
added
release-note
| @@ -25,7 +25,7 @@ options: | |||
| If true, a public, external service is created for the container(s) which are run | |||
| - name: generator | |||
| usage: | | |||
| The name of the API generator to use. Default is 'deployment/v1beta1' if --restart=Always, otherwise the default is 'job/v1'. This will happen only for cluster version at least 1.2, for olders we will fallback to 'run/v1' for --restart=Always, 'run-pod/v1' for others. | |||
| The name of the API generator to use. Default is 'deployment/v1beta1' if --restart=Always, 'job/v1' for OnFailure and 'pod/v1' for Never. This will happen only for cluster version at least 1.2, for olders we will fallback to 'run/v1' for --restart=Always, 'run-pod/v1' for others. | |||
There was a problem hiding this comment.
Hm, but we don't support "restart=Never creates pods" in 1.2 (we're adding this in 1.3). I'd however love to keep this succinct...
k8s-github-robot
added
the
needs-rebase
k8s-github-robot
removed
the
needs-rebase
|
@bgrant0607 @janetkuo rebase and updated except for the new tests in e2e. ptal |
|
GCE e2e build/test passed for commit d76fa8a. |
This was referenced May 31, 2016
janetkuo
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit d76fa8a. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24533.
@bgrant0607 @janetkuo ptal
/fyi @thockin