Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl suggest for get (list, ps), and delete(rm) #25181

Merged
merged 1 commit into from
May 13, 2016
Merged

kubectl suggest for get (list, ps), and delete(rm) #25181

merged 1 commit into from
May 13, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented May 5, 2016 •
edited
Loading

Pull Request Guidelines

  1. Please read our contributor guidelines.
  2. See our developer guide.
  3. Follow the instructions for labeling and writing a release note for this PR in the block below.
kubectl "rm" will suggest using "delete"; "ps" and "list" will suggest "get".

Before:

$ kubectl ps 
Error: unknown command "ps" for "kubectl"
Run 'kubectl --help' for usage.

After:

$ kubectl ps 
Error: unknown command "ps" for "kubectl"

Did you mean this?
    get

Run 'kubectl --help' for usage.

Ref #25180

Analytics

@janetkuo janetkuo added area/kubectl team/ux release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 5, 2016
@janetkuo janetkuo mentioned this pull request May 5, 2016
Closed
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 5, 2016
@adohe-zz
Copy link

adohe-zz commented May 5, 2016

Looks good.

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2016
@janetkuo
Copy link
Member Author

janetkuo commented May 5, 2016

@k8s-bot node e2e test this issue: #25210

0xmichalis
0xmichalis reviewed May 6, 2016
View reviewed changes
pkg/kubectl/cmd/get.go
@@ -92,6 +92,7 @@ func NewCmdGet(f *cmdutil.Factory, out io.Writer) *cobra.Command {
err := RunGet(f, out, cmd, args, options)
cmdutil.CheckErr(err)
},
SuggestFor: []string{"list", "ps"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smarterclayton you had opinions on list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for now. Merge away.

@0xmichalis
Copy link
Contributor

@kubernetes/kubectl

@deads2k
Copy link
Contributor

deads2k commented May 6, 2016

I like the idea and I don't see us creating those commands.

@fabianofranz fabianofranz mentioned this pull request May 6, 2016
Merged
@roberthbailey
Copy link
Contributor

@smarterclayton any comments before this PR merges?

@janetkuo janetkuo added the priority/backlog Higher priority than priority/awaiting-more-evidence. label May 11, 2016
@bgrant0607 bgrant0607 removed the priority/backlog Higher priority than priority/awaiting-more-evidence. label May 12, 2016
@k8s-bot
Copy link

k8s-bot commented May 13, 2016

GCE e2e build/test passed for commit 181627e.

@j3ffml j3ffml merged commit e9aecf6 into kubernetes:master May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j3ffml j3ffml

Labels
area/kubectl lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.