Sort resources in quota errors to avoid duplicate events #25161
Merged
+50
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
ncdc
added
the
release-note
| @@ -91,12 +92,14 @@ func (q *quotaAdmission) Admit(a admission.Attributes) (err error) { | |||
| } | |||
|
|
|||
| // prettyPrint formats a resource list for usage in errors | |||
| // it outputs in sorted order | |||
derekwaynecarr
force-pushed
the
format_quota_error
branch
from
9bed038 to
ca7a8b5
Compare
|
@pmorie complex scenario added |
k8s-github-robot
added
size/M
pmorie
added
the
lgtm
|
GCE e2e build/test passed for commit ca7a8b5. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit ca7a8b5. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1333122
Errors describing why a request was rejected to quota would get variable responses (cpu=x,memory=y or memory=x,cpu=y) which caused duplicate events for the same root cause.
/cc @ncdc @jwforres