Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade installed packages when building hyperkube to improve the security profile #25114

Merged
merged 1 commit into from
May 6, 2016

Conversation

aaronlevy
Copy link
Contributor

Fixes: #25097

@k8s-bot
Copy link

k8s-bot commented May 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 4, 2016
@k8s-bot
Copy link

k8s-bot commented May 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented May 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@roberthbailey
Copy link
Contributor

ok to test

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2016
@roberthbailey
Copy link
Contributor

/cc @thockin since he agreed to this change in the referenced issue.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2016
@roberthbailey
Copy link
Contributor

@aaronlevy Would you like this change to have a release note?

@aaronlevy
Copy link
Contributor Author

@roberthbailey I guess I'd defer to you on that. I'm fine with none, or PR title, or I can add more detail if you like.

Also, the test failure looks to be related to: #25153

@roberthbailey roberthbailey added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 4, 2016
@roberthbailey roberthbailey changed the title cluster/images/hyperkube: Upgrade installed packages Upgrade installed packages when building hyperkube to improve the security profile May 4, 2016
@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2016
@k8s-github-robot
Copy link

@roberthbailey
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2016
@roberthbailey
Copy link
Contributor

k8s-bot test this issue: #25153

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2016
@k8s-bot
Copy link

k8s-bot commented May 4, 2016

GCE e2e build/test passed for commit dd8c358.

@luxas
Copy link
Member

luxas commented May 5, 2016

LGTM for me too :)

@roberthbailey roberthbailey merged commit c9442ee into kubernetes:master May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants