reduce conflict retries #25091
Merged
reduce conflict retries #25091
+86
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/M
| @@ -51,6 +52,11 @@ type quotaEvaluator struct { | |||
| // We track the lookup result here so that for repeated requests, we don't look it up very often. | |||
| liveLookupCache *lru.Cache | |||
| liveTTL time.Duration | |||
| // updatedQuotas holds a cache of quotas that we've updated. This is used to pull the "really latest" during back to | |||
| // back quota evaluations that touch the same quota doc. This only works because we can compare etcd resourceVersions | |||
| // for the same resource as integers. Before this change: 22 updates with 12 conflicts. after this change: | |||
deads2k
added
release-note-none
|
comments addressed. |
|
@derekwaynecarr bump |
|
|
||
| // CompareResourceVersion compares etcd resource versions. Outside this API they are all strings, | ||
| // but etcd resource versions are special, they're actually ints, so we can easily compare them. | ||
| func (a APIObjectVersioner) CompareResourceVersion(lhs, rhs runtime.Object) int { |
deads2k
force-pushed
the
reduce-conflicts
branch
2 times, most recently
from
3bde19a to
8980637
Compare
| @@ -70,8 +70,15 @@ func NewResourceQuota(client clientset.Interface, registry quota.Registry, numEv | |||
| }, nil | |||
| } | |||
|
|
|||
| var runningTotal time.Duration | |||
There was a problem hiding this comment.
is this left over debugging?
i dont see it used anywhere...
|
A few requests, and I am wondering if we can have the look-aside cache get purged somewhere else or via a TTL such that if a namespace or quota is purged, they are not left lingering in the look-aside cache. Let me know if I am mistaking anything. This is a good bug fix, so I see no issue getting it in 1.3. |
|
LGTM, thanks! |
derekwaynecarr
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 02c0181. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates quota admission conflicts due to latent caches on the same API server.
@derekwaynecarr