Clarify supported version skew between masters, nodes, and clients #25087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikehz
added
kind/documentation
k8s-github-robot
added
kind/design
| possible. | ||
|
|
||
| Different components are expected to be compatible across different amounts of | ||
| skew: cluster components (master and node components) should work across two |
There was a problem hiding this comment.
"cluster components (master and node components) should work across two minor versions but should be at a version no newer than the master" is confusing because you are grouping the components together but then comparing them to each other. I think it would be clearer to root everything around the master version and then talk about compatibility / skew with that as a reference point.
|
@roberthbailey Good point; done. |
|
LGTM, please squash. I'll wait for @bgrant0607 to review before adding the label. |
|
Squashed; PTAL @bgrant0607. |
|
@ihmccreery Please assign PRs to whomever you'd like to review them. |
|
LGTM, thanks. |
bgrant0607
added
the
lgtm
|
GCE e2e build/test passed for commit e618e33. |
|
Automatic merge from submit-queue |
This was referenced Jun 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #22897.
cc @bgrant0607 @roberthbailey