Conversions have kube-isms and are not portable for downstream #25033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/M
smarterclayton
force-pushed
the
use_upstream_conversion
branch
from
b70bad0 to
c197f33
Compare
k8s-github-robot
added
size/L
| func DeepCopy_unversioned_ServerAddressByClientCIDR(in ServerAddressByClientCIDR, out *ServerAddressByClientCIDR, c *conversion.Cloner) error { | ||
| out.ClientCIDR = in.ClientCIDR | ||
| out.ServerAddress = in.ServerAddress | ||
| return nil | ||
| } | ||
|
|
||
| func DeepCopy_unversioned_Time(in Time, out *Time, c *conversion.Cloner) error { |
There was a problem hiding this comment.
Function moved later in the file, diff is weird.
|
This would be nice downstream. |
smarterclayton
force-pushed
the
use_upstream_conversion
branch
from
c197f33 to
902ef28
Compare
|
LGTM |
wojtek-t
added
release-note-none
k8s-github-robot
added
the
needs-rebase
smarterclayton
force-pushed
the
use_upstream_conversion
branch
from
902ef28 to
afbfcbf
Compare
k8s-github-robot
removed
lgtm
wojtek-t
added
the
lgtm
|
lgtm |
k8s-github-robot
added
the
needs-rebase
|
@smarterclayton can you rebase pls? (need to pick this for origin->k8s rebase) |
Some minor fixes to enable generators for OpenShift and others who need to generate conversions on Kube API groups outside the core.
We need to break the circular dependency on generation to the scheme.
smarterclayton
force-pushed
the
use_upstream_conversion
branch
from
afbfcbf to
adf3c38
Compare
k8s-github-robot
removed
lgtm
smarterclayton
added
the
lgtm
|
GCE e2e build/test passed for commit adf3c38. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit adf3c38. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes to enable generators for OpenShift and others who need
to generate conversions on Kube API groups outside the core.
@deads2k