Fix kubectl create secret/configmap to allow = values #24989
Conversation
derekwaynecarr
added
the
release-note-none
| }, | ||
| { | ||
| name: "err 2", | ||
| input: "key=value=", | ||
| err: true, | ||
| key: "key", |
There was a problem hiding this comment.
I feel like this should be an error
There was a problem hiding this comment.
value= could happen in base64 output, no?
There was a problem hiding this comment.
we should ignore anything after the first =
There was a problem hiding this comment.
The root bug was the user needed the secret to store a base64 encoded value because the application consumed base64. So for example, "haha" encodes as "aGFoYQ==", the user should be able to say key=aGFoYQ== because "aGFoYQ==" is what his application is consuming. Internally, the secret will store the double encoded form, YUdGb1lRPT0=
There was a problem hiding this comment.
Yeah, i think this should be valid, then. Carry on!
There was a problem hiding this comment.
How about cases for "==key=value" and "key===value=="
k8s-github-robot
added
the
size/M
|
lgtm |
deads2k
added
the
lgtm
derekwaynecarr
force-pushed
the
fix_secret_cmd
branch
from
97e12af to
b9a5cf9
Compare
k8s-github-robot
removed
the
lgtm
derekwaynecarr
added
the
lgtm
derekwaynecarr
force-pushed
the
fix_secret_cmd
branch
from
b9a5cf9 to
25ed62c
Compare
k8s-github-robot
removed
the
lgtm
derekwaynecarr
added
the
lgtm
|
Rebased and reapplied lgtm since there was no code change. |
|
GCE e2e build/test passed for commit 25ed62c. |
|
🏆 |
derekwaynecarr
added
release-note
Bug 1592653: detect int64 overflow when converting volume sizes Origin-commit: 2ca1c4f2d59ea4fb171c10923b2f24d910be79f5
Fixes #24488
@pmorie - PTAL