GCI: Update the command to get the image #24987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
dchen1107
added
cherrypick-candidate
release-note
|
Removing label |
|
We need this patch in release-1.2 also, please label it |
dchen1107
added
cherrypick-candidate
release-note-none
k8s-github-robot
added
the
size/XS
|
GCE e2e build/test passed for commit 967fd49. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 967fd49. |
|
Automatic merge from submit-queue |
|
@dchen1107 I think you need to replace "release-note-label" with "release-note". Otherwise the cherry-pick #24999 will not be merged |
dchen1107
added
release-note
roberthbailey
added
the
cherry-pick-approved
roberthbailey
added a commit
that referenced
this pull request
May 4, 2016
…-#24987-upstream-release-1.2 Automated cherry pick of #24987
|
Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ry-pick-of-#24987-upstream-release-1.2 Automated cherry pick of kubernetes#24987
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…ry-pick-of-#24987-upstream-release-1.2 Automated cherry pick of kubernetes#24987
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
May 23, 2020
Bug 1827071: UPSTREAM: 90792: Send a nicer event when resizing attached Cinder volume Origin-commit: 46de616bdb52164a210104b1ee4ddc0550a42d63
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
May 27, 2020
Bug 1827071: UPSTREAM: 90792: Send a nicer event when resizing attached Cinder volume Origin-commit: 46de616bdb52164a210104b1ee4ddc0550a42d63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we announced public GCI, we used the project google-containers to host GCI release images. However, later we encountered a licence issue and the administrators of google-containers project decided to remove this project from gcloud commands. According, we should list GCI images with the flag "--project google-containers". But the same image is listed twice during this transient period. This PR updates the code of getting the GCI image, which works during the transient period and after the google-containers project change finishes.
@roberthbailey @dchen1107 @zmerlynn please review it.
cc/ @wonderfly @fabioy FYI