Quobyte Volume plugin #24977
Quobyte Volume plugin #24977
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
k8s-github-robot
added
kind/api-change
johscheuer
force-pushed
the
quobyte-plugin
branch
2 times, most recently
from
4b4dc0b to
ca292c8
Compare
|
Ping, could somebody trigger the test? |
|
ok to test. |
|
@saad-ali maybe you can take this one? It's a storage plugin. |
|
Huamin, can you take a first pass at reviewing this PR. |
| <!-- END MUNGE: EXAMPLE ./quobyte-pod.yaml --> | ||
|
|
||
| Parameters: | ||
| * **registry** Quobyte registry and port to use to mount the volume. |
There was a problem hiding this comment.
Is the registry a host name, IP address or either?
|
@johscheuer What's would be the mid and long term maintenance plan for this volume type? We dont have an area\storage maintainer who's familiar with Quobyte to support this in-tree, and i'm fearful that if we have to change the Volume framework in a way that touches this volume plugin we wouldn't be able to fully test or validate the function. Could you hook into the exiting Flex volume plugin instead and provide any requirements or updates to Flex plugin required for enablement of Quobyte? The flex volume plugin would allow this plugin to live out of the kube source tree and would be a good source of requirements and enhancements for that plugin type. |
| }, | ||
| registry: registry, | ||
| volume: source.Volume, | ||
| path: source.Path, |
There was a problem hiding this comment.
note, Path could be empty in types.go
There was a problem hiding this comment.
@childsb Quobyte engineering will maintain it. Generally this is not complicated stuff as it is just a mapping that decouples Pod descriptions from the actual setup of the underlying infrastructure. Most changes should be guarded by the tests (that's what they are for in the end), if it still breaks, we'll fix it.
We looked at Flexvolume but it declares itself "alpha". As people want to use this in production, Flexvolume didn't seem the way to go.
|
@johscheuer PR needs rebase |
k8s-github-robot
added
the
needs-rebase
johscheuer
force-pushed
the
quobyte-plugin
branch
from
315a6ff to
9ae31b6
Compare
k8s-github-robot
removed
the
needs-rebase
|
GCE e2e build/test passed for commit 9ae31b60eb1e07529e71955420115f4bbf4f7edb. |
|
@johscheuer PR needs rebase |
k8s-github-robot
added
the
needs-rebase
|
@jsafrane can you tag it? |
jsafrane
added
release-note-none
johscheuer
force-pushed
the
quobyte-plugin
branch
from
9ae31b6 to
bcc7bbf
Compare
|
@rootfs this would be awesome :) |
johscheuer
force-pushed
the
quobyte-plugin
branch
from
bcc7bbf to
eed4238
Compare
|
@johscheuer sorry this has taken so long. @jsafrane and @rootfs are going to try and get this merged in-time for Kube 1.4. The Storage SIG is a bit bandwidth constrained, especially on the review side, but we're really trying to grow the community to improve that. We are excited to have Quobyte support in-tree. Thanks for contributing and we hope to see you around the Storage SIG meetings! |
k8s-github-robot
removed
the
needs-rebase
|
GCE e2e build/test passed for commit bcc7bbf55909136079d470a877e27460d899b81f. |
|
GCE e2e build/test passed for commit eed4238. |
|
@jsafrane everything is green :) |
|
lgtm on behalf of @rootfs |
jsafrane
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit eed4238. |
|
Automatic merge from submit-queue |
Bug 1835785: UPSTREAM: 90378: bugfix: initcontainer wasn't considered when calculate resource request Origin-commit: 04a55927c6462c55bb7c4ef6ab20fcbc9910d5ea
@quofelix and myself developed a volume plugin for Quobyte which is a software-defined storage solution. This PR allows Kubernetes users to mount a Quobyte Volume inside their containers over Kubernetes.
Here are some further informations about Quobyte and Storage for containers
This change is