GCI/Trusty: Support ABAC authorization #24950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
|
@roberthbailey @dchen1107 @cjcullen please review it. cc/ @fabioy @zmerlynn @wonderfly FYI |
|
LGTM. I'll let it simmer for a bit in case anybody else has comments. |
|
@andyzheng0831 I think I'm not the person you meant to tag... |
|
@danwinship sorry for mis-tagging you. |
|
@dchen1107 @roberthbailey do you have any comments for this change? Thanks! |
roberthbailey
added
the
lgtm
k8s-github-robot
removed
the
lgtm
|
@cjcullen @roberthbailey please add "release-note" label for it, we can use the PR title for the changelog. Thanks |
roberthbailey
added
release-note
|
done. |
|
GCE e2e build/test passed for commit 27c9ee3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for supporting the ABAC authorization added in PR #24210. It is tested on GCI and Ubuntu Trusty with two modes, i.e., entire cluster on GCI/Trusty and hybrid mode with only master on GCI/Trusty.