Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e tests for GKE cluster with local SSD. #24884

Merged
merged 2 commits into from
May 22, 2016
Merged

E2e tests for GKE cluster with local SSD. #24884

merged 2 commits into from
May 22, 2016

Conversation

vulpecula
Copy link

The test cover node pool with local SSD creation and scheduling a pod that writes and reads from it. Pod access local disk via hostPath.

E2e tests for GKE cluster with local SSD.
-OR-

spxtr
spxtr reviewed Apr 27, 2016
View reviewed changes
test/e2e/gke_local_ssd.go
})
})

func createNodePoolWIthLocalSsds(nodePoolName string) {
Copy link
Contributor

@spxtr spxtr Apr 27, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: WIth

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Apr 27, 2016
@vulpecula vulpecula added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 28, 2016
@vulpecula
Copy link
Author

PTAL

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2016
@spxtr
Copy link
Contributor

spxtr commented May 2, 2016

You'll have to redo the job config changes against the test-infra repo. Sorry for the inconvenience.

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to design. kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2016
@googlebot
Copy link

CLAs look good, thanks!

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to design. kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 19, 2016
spxtr
spxtr reviewed May 19, 2016
View reviewed changes
test/e2e/gke_local_ssd.go
@@ -0,0 +1,107 @@
/*
Copyright 2015 The Kubernetes Authors All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@spxtr
Copy link
Contributor

spxtr commented May 19, 2016

Looks fine to me. I would ask someone more knowledgeable about go for a review too. Can this test be run in parallel with other tests? If not, you should tack [Serial] onto the test name.

@k8s-github-robot
Copy link

@vulpecula
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@vulpecula vulpecula assigned fabioy and vulpecula and unassigned vulpecula and fabioy May 20, 2016
@spxtr
Copy link
Contributor

spxtr commented May 20, 2016

@k8s-bot unit test this issue: #25967

@vulpecula vulpecula assigned fabioy and unassigned vulpecula May 20, 2016
fabioy
fabioy reviewed May 20, 2016
View reviewed changes
test/e2e/gke_local_ssd.go
func createNodePoolWithLocalSsds(nodePoolName string) {
framework.Logf("Create node pool: %s with local SSDs in cluster: %s ",
nodePoolName, framework.TestContext.CloudConfig.Cluster)
out, err := exec.Command("gcloud", "alpha", "container", "node-pools", "create",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file an issue against me to change this to the GA track? gcloud changes should be going out soon.

@fabioy fabioy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 22, 2016

GCE e2e build/test passed for commit e676fc5.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 52707ac into kubernetes:master May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabioy fabioy

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vulpecula @spxtr @googlebot @k8s-github-robot @k8s-bot @fabioy