Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 3rd party objects to kubectl label #24882

Merged
merged 1 commit into from
May 30, 2016
Merged

Add support for 3rd party objects to kubectl label #24882

merged 1 commit into from
May 30, 2016
+67 −2

Conversation

brendandburns
Copy link
Contributor

Fixes #24583

@kubernetes/rh-ux

@brendandburns brendandburns added area/kubectl release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 27, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 27, 2016
@liggitt
Copy link
Member

liggitt commented Apr 27, 2016

does the same applies to annotate?

@bgrant0607
Copy link
Member

cc @kubernetes/kubectl

@bgrant0607 bgrant0607 assigned janetkuo and unassigned bgrant0607 Apr 28, 2016
@adohe-zz
Copy link

@liggitt @brendandburns I think we should also apply this to annotate cmd.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2016
@janetkuo janetkuo mentioned this pull request May 3, 2016
Closed
@janetkuo
Copy link
Member

janetkuo commented May 4, 2016

Suggest adding a test

@brendandburns brendandburns assigned janetkuo and unassigned bgrant0607 May 6, 2016
@brendandburns
Copy link
Contributor Author

@janetkuo refactored to make testing easier, and test added, ptal.

thanks!
--brendan

@brendandburns
Copy link
Contributor Author

@janetkuo friendly Monday ping on this one.

Thanks!

@brendandburns
Copy link
Contributor Author

@janetkuo ping on this one, thanks.

@adohe-zz
Copy link

LGTM.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2016
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2016
@janetkuo
Copy link
Member

Sorry, needs a rebase now.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 16, 2016
@brendandburns
Copy link
Contributor Author

@k8s-bot unit test this please issue: #25645

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2016
@janetkuo
Copy link
Member

Please squash and this need another rebase now.

@brendandburns
Copy link
Contributor Author

squashed and rebased

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 23, 2016
@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2016
@brendandburns
Copy link
Contributor Author

@k8s-bot unit test this issue: #26181

@wojtek-t wojtek-t added this to the v1.3 milestone May 30, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 30, 2016

GCE e2e build/test passed for commit dac0931.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6a234a2 into kubernetes:master May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janetkuo janetkuo

Labels
area/kubectl lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
10 participants
@brendandburns @liggitt @bgrant0607 @adohe-zz @janetkuo @k8s-github-robot @k8s-bot @googlebot @deads2k @wojtek-t