Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeletingLoadBalancer event generation. #24833

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Fix DeletingLoadBalancer event generation. #24833

merged 1 commit into from
Apr 27, 2016
+2 −2

Conversation

a-robinson
Copy link
Contributor

release-note:

Fix DeletingLoadBalancer event generation.

Also patch up a log statement to log the service's namespace and name
rather than potentially just logging kind:"" apiVersion:"".

It doesn't work as written because service is always nil on this line. If it wasn't, then we wouldn't have taken this branch. deltaService is what contains the info that we have about the service.

Example of how the event generation fails as currently written:

E0426 22:18:41.726835      10 event.go:257] Could not construct reference to: '&api.Service{TypeMeta:unversioned.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:api.ObjectMeta{Name:"", GenerateName:"", Namespace:"", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:unversioned.Time{Time:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*unversioned.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil)}, Spec:api.ServiceSpec{Type:"", Ports:[]api.ServicePort(nil), Selector:map[string]string(nil), ClusterIP:"", ExternalIPs:[]string(nil), LoadBalancerIP:"", SessionAffinity:""}, Status:api.ServiceStatus{LoadBalancer:api.LoadBalancerStatus{Ingress:[]api.LoadBalancerIngress(nil)}}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'DeletingLoadBalancer' 'Deleting load balancer'

@a-robinson
Fix DeletingLoadBalancer event generation.
ed15931 
Also patch up a log statement to log the service's namespace and name
rather than potentially just logging `kind:"" apiVersion:""`.
@a-robinson a-robinson added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherrypick-candidate labels Apr 27, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@a-robinson a-robinson added this to the v1.2 milestone Apr 27, 2016
@a-robinson
Copy link
Contributor Author

cc @girishkalele

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 27, 2016

GCE e2e build/test passed for commit ed15931.

@davidopp
Copy link
Member

LGTM

@davidopp davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Apr 27, 2016

GCE e2e build/test passed for commit ed15931.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a907794 into kubernetes:master Apr 27, 2016
@zmerlynn zmerlynn added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 27, 2016
@roberthbailey roberthbailey mentioned this pull request May 4, 2016
Merged
roberthbailey added a commit that referenced this pull request May 5, 2016
@roberthbailey
Merge pull request #25155 from roberthbailey/automated-cherry-pick-of…
5ffeaef 
…-#24833-upstream-release-1.2

Automated cherry pick of #24833 upstream release 1.2
@roberthbailey
Copy link
Contributor

@eparis I merged the cherry pick for this PR but the bot hasn't noticed yet (and it's definitely been running according to the bot stats tab on http://cherrypick.k8s.io/#/info). Any ideas why?

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@roberthbailey
Merge pull request kubernetes#25155 from roberthbailey/automated-cher…
062ab51 
…ry-pick-of-#24833-upstream-release-1.2

Automated cherry pick of kubernetes#24833 upstream release 1.2
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@roberthbailey
Merge pull request kubernetes#25155 from roberthbailey/automated-cher…
8e2e7cd 
…ry-pick-of-#24833-upstream-release-1.2

Automated cherry pick of kubernetes#24833 upstream release 1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
8 participants
@a-robinson @k8s-cherrypick-bot @k8s-bot @davidopp @k8s-github-robot @roberthbailey @zmerlynn @googlebot