Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release_1_3 clientset in update-codegen #24826

Merged
merged 2 commits into from
May 26, 2016
Merged

Add release_1_3 clientset in update-codegen #24826

merged 2 commits into from
May 26, 2016

Conversation

caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Apr 26, 2016 •
edited
Loading

Add release_1_3 clientset in update-codegen to keep it update-to-date; update the generated clientset.

@caesarxuchao caesarxuchao added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 26, 2016
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 26, 2016
@krousey krousey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2016
@caesarxuchao
Copy link
Member Author

@k8s-bot e2e test this, issue #24905

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2016
@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2016
@caesarxuchao caesarxuchao added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 2, 2016
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@caesarxuchao caesarxuchao added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 5, 2016
@caesarxuchao
Copy link
Member Author

test-cmd.sh fails with

error: server version (&version.Info{Major:"1", Minor:"3+", GitVersion:"v1.3.0-alpha.3.284+3b6491aa8247e6-dirty", GitCommit:"3b6491aa8247e6d7755c086a7c6dae38ae2f216d", GitTreeState:"dirty", BuildDate:"2016-05-05T17:34:51Z", GoVersion:"go1.6.1", Compiler:"gc", Platform:"linux/amd64"}) differs from client version (version.Info{Major:"1", Minor:"3+", GitVersion:"v1.3.0-alpha.3.284+3b6491aa8247e6", GitCommit:"3b6491aa8247e6d7755c086a7c6dae38ae2f216d", GitTreeState:"clean", BuildDate:"2016-05-05T17:14:54Z", GoVersion:"go1.6.1", Compiler:"gc", Platform:"linux/amd64"})!

@k8s-github-robot k8s-github-robot assigned ikehz and unassigned krousey May 6, 2016
@caesarxuchao caesarxuchao added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 8, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2016
@caesarxuchao caesarxuchao added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 10, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2016
@caesarxuchao caesarxuchao added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 23, 2016
nikhiljindal
nikhiljindal reviewed May 24, 2016
View reviewed changes
hack/update-codegen.sh
@@ -43,11 +43,10 @@ setgen=$(kube::util::find-binary "set-gen")
# update- and verify- scripts.
${clientgen} "$@"
${clientgen} -t "$@"

${clientgen} --clientset-name="release_1_3" --input="api/v1,extensions/v1beta1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt we add autoscaling/v1,batch/v1 here?
What about alpha groups? apps and metrics.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add them all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually just batch/v1 and autoscaling/v1, since only they are added in the internalclientset, I think that means people only need these two for now.

@nikhiljindal
Copy link
Contributor

Shouldnt this be for 1.3?

@caesarxuchao caesarxuchao added this to the v1.3 milestone May 24, 2016
@caesarxuchao
Copy link
Member Author

Yeah, it should. Thanks for the reminder.

@caesarxuchao
Copy link
Member Author

There is only a started.json in the failed e2e test.

@caesarxuchao
Copy link
Member Author

@k8s-bot e2e test this, issue #IGNORE.

@caesarxuchao
Copy link
Member Author

@k8s-bot e2e test this, issue #26271.

@caesarxuchao
Copy link
Member Author

https://console.cloud.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/24826/kubernetes-pull-build-test-e2e-gce/41982/

@caesarxuchao caesarxuchao mentioned this pull request May 25, 2016
Merged
@caesarxuchao
Copy link
Member Author

e2e seems to have some infrastructure issues.
@k8s-bot e2e test this, issue #IGNORE.

@caesarxuchao caesarxuchao assigned nikhiljindal and unassigned ikehz May 26, 2016
@caesarxuchao caesarxuchao added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 26, 2016
@caesarxuchao
Copy link
Member Author

@nikhiljindal I added those two groups. Please take a look and remove the LGTM if you find any problem.

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 26, 2016

GCE e2e build/test passed for commit 44591bf.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 44de311 into kubernetes:master May 26, 2016
k8s-github-robot pushed a commit that referenced this pull request Jun 2, 2016
Merge pull request #26251 from caesarxuchao/add-serializer
cf234ab 
Automatic merge from submit-queue

Add direct serializer

Fix #25589. Implemented a direct codec that doesn't do conversion, but sets the group, version and kind before serialization as Clayton suggested [here](#25589 (comment)).

First commit is cherry-picked from #24826.

@kubernetes/sig-api-machinery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
7 participants
@caesarxuchao @k8s-github-robot @nikhiljindal @k8s-bot @krousey @ikehz @googlebot