Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cAdvisor event storage by default #24771

Merged
merged 1 commit into from
May 27, 2016
Merged

Disable cAdvisor event storage by default #24771

merged 1 commit into from
May 27, 2016

Conversation

timstclair
Copy link

Fixes #24698

@timstclair timstclair added area/cadvisor sig/node Categorizes an issue or PR as relevant to SIG Node. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 26, 2016
@timstclair timstclair added this to the v1.3 milestone Apr 26, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2016
@timstclair
Copy link
Author

Oops, looks like this requires google/cadvisor#1243 or google/cadvisor#1242.

@timstclair timstclair assigned timstclair and unassigned vishh Apr 26, 2016
@timstclair timstclair mentioned this pull request Apr 27, 2016
Open
@timstclair timstclair mentioned this pull request May 26, 2016
Closed
@timstclair
Copy link
Author

This is still blocked by #25914, but since it's on the 1.3 milestone I'd like to get it reviewed so it can be merged as soon as the dependencies are met (assuming tests pass at that point).

@timstclair timstclair assigned vishh and unassigned timstclair May 26, 2016
@vishh
Copy link
Contributor

vishh commented May 26, 2016

LGTM

@vishh vishh added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 26, 2016
@timstclair timstclair removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 26, 2016
@timstclair
Copy link
Author

Dependency merged: removing do-not-merge

@timstclair
Copy link
Author

@k8s-bot test this, issue #IGNORE

@timstclair
Copy link
Author

@k8s-bot node e2e test this, issue #24508

@k8s-bot
Copy link

k8s-bot commented May 27, 2016

GCE e2e build/test passed for commit 2201554.

@a-robinson a-robinson merged commit cddf564 into kubernetes:master May 27, 2016
@timstclair timstclair deleted the event-store branch August 31, 2016 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vishh vishh

Labels
area/cadvisor lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
8 participants
@timstclair @vishh @k8s-bot @k8s-teamcity-mesosphere @googlebot @a-robinson @k8s-github-robot @tallclair