Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusty: Add retry in curl commands #24749

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Trusty: Add retry in curl commands #24749

merged 1 commit into from
Apr 26, 2016

Conversation

andyzheng0831
Copy link

This fix is for improving robustness in fetch critical metadata files when the metadata server is temporarily unreachable.

@roberthbailey @zmerlynn @dchen1107 please review it.

cc/ @fabioy @wonderfly FYI.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 25, 2016
@dchen1107 dchen1107 assigned dchen1107 and unassigned zmerlynn Apr 25, 2016
@dchen1107 dchen1107 added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 25, 2016
@dchen1107
Copy link
Member

LGTM

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 25, 2016

GCE e2e build/test passed for commit 72f3cb6.

@andyzheng0831
Copy link
Author

@k8s-bot unit test this, issue #21640

@andyzheng0831
Copy link
Author

Reviewers, do you mind to mark this as a cherry-pick candidate? Thanks!

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 773bb77 into kubernetes:master Apr 26, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@zmerlynn zmerlynn added this to the v1.2 milestone Apr 27, 2016
@zmerlynn zmerlynn added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 27, 2016
@andyzheng0831 andyzheng0831 mentioned this pull request Apr 27, 2016
Merged
@roberthbailey roberthbailey added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 27, 2016
k8s-github-robot pushed a commit that referenced this pull request Apr 27, 2016
Merge pull request #24871 from andyzheng0831/automated-cherry-pick-of…
9a27dd1 
…-#24749-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of #24749

Cherry pick of #24749 on release-1.2.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@andyzheng0831 andyzheng0831 deleted the enhance branch April 28, 2016 01:13
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#24871 from andyzheng0831/automated-cher…
0fe9a44 
…ry-pick-of-#24749-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of kubernetes#24749

Cherry pick of kubernetes#24749 on release-1.2.
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
Merge pull request kubernetes#24871 from andyzheng0831/automated-cher…
40072e0 
…ry-pick-of-#24749-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of kubernetes#24749

Cherry pick of kubernetes#24749 on release-1.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
10 participants
@andyzheng0831 @dchen1107 @k8s-bot @k8s-github-robot @k8s-cherrypick-bot @k8s-teamcity-mesosphere @zmerlynn @googlebot @roberthbailey @wojtek-t