-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cinder volume dir umount issue #24717 #24718
Conversation
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
https://github.com/kubernetes/kubernetes/blob/master/pkg/util/mount/mount.go#L112 should the |
@zhouhaibing089 Thanks. Yes, this |
Could anyone guide me how to find the detail errors for below FAILURE?
I can only see below error message in build log, but no much clue
|
@chengyli you could rebase your code to get a clean test again. I thought the test has failed for a long time, though not the way failed like you met. |
fix kubernetes#24717 If kubelet root-dir is a symlink, the pod's cinder volume dir can't be umounted even after pod is deleted. This patch reads target path of symlink before comparing with entries in proc mounts.
@saad-ali any actions reuiqred from my side? And who could help to review the code? |
I'll take a look. CC @kubernetes/sig-storage |
LGTM |
@k8s-bot ok to test |
Yes, that does appear to be the case. |
@saad-ali |
GCE e2e build/test passed for commit 1fb33aa. |
@saad-ali , could you please help to merge the pr, thanks! |
It will automatically be merged by the merge-bot. The submit queue is pretty backed up, so it might take a few days. |
@saad-ali Got it, thanks! |
@chengyli I'm merging a bunch of small PRs to clear out the queue. In it goes. |
fix #24717
If kubelet root-dir is a symlink, the pod's cinder volume dir can't be
umounted even after pod is deleted.
This patch reads target path of symlink before comparing with entries in
proc mounts.