We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

Hi, it's great to see more cloud providers!

Can you take a look at making CLA bot happy with all of the committers?

Hello @lavalamp!

@vipulsabhaya @abithap need Google's CLA signed (https://cla.developers.google.com/clas)

I do have a corporate CLA signed. Maybe an email address issue?

Looks like @abithap needs to sign a CLA.

Can you add to this PR a file pkg/cloudprovider/providers/vsphere/OWNERS and add appropriate entries? (look at e.g. pkg/OWNERS for an example) This is so change PRs can be assigned to you, and so we know who to direct people to if they have questions or file bugs etc.

@lavalamp I have signed the CLA. Can you please re-run the CLA test when you get a chance and see if it passes now? thanks

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@lavalamp changes made, let me know if there is something else to update or change

ok to test

Its pretty simple. You'll see .drone.sec in https://github.com/vmware/govmomi/blob/master/.drone.sec but that file isn't being included in Godeps/_workspace/src/github.com/vmware/govmomi/

verify-godep is checking is the contents in Godeps are actually the ones that are supposedly referenced and in this case, they are not. that file is missing.

It seems the right solution is to just add that file to Godeps

@karlkfi @eparis thank you, looks like that was the difference. .drone.sec was being skipped by .gitignore by default

=== RUN   TestReadConfig
--- PASS: TestReadConfig (0.00s)
=== RUN   TestNewVSphere
--- SKIP: TestNewVSphere (0.00s)
    vsphere_test.go:87: No config found in environment
=== RUN   TestVSphereLogin
--- SKIP: TestVSphereLogin (0.00s)
    vsphere_test.go:99: No config found in environment
=== RUN   TestZones
--- FAIL: TestZones (0.07s)
    vsphere_test.go:127: Failed to construct/authenticate vSphere: Post https://:/sdk: dial tcp :0: getsockopt: connection refused
=== RUN   TestInstances
--- SKIP: TestInstances (0.00s)
    vsphere_test.go:148: No config found in environment
FAIL
FAIL    k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere   0.253s

Looks like a more legit problem this time :)

LGTM assuming tests will pass :)

@lavalamp build failure details are not accessible, any way I can get that information?

@pwittrock or @ixdy-- can one of you tell us the correct node e2e status link? For the record, since I'm going to restart it, the link was https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/pull/24703/node-pull-build-e2e-test/5153/build-log.txt.

@k8s-bot node test this issue #IGNORE

GCE e2e build/test passed for commit f7b3cf3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit f7b3cf3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue