-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update hack/build-go to build federation/cmd/federated-apiserver as well #24574
update hack/build-go to build federation/cmd/federated-apiserver as well #24574
Conversation
GCE e2e build/test failed for commit 1c214325f2b21485b3ab15a4f1469e86269283b6. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
1c21432
to
b77c408
Compare
GCE e2e build/test failed for commit b77c4086eb8732e220e54c4f3084b7e99de452dd. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
I dont know why it cant find @ixdy Any idea? Is that something to do with the way we have setup jenkins |
@nikhiljindal does |
I don't understand why crossbuild would fail, but it'd help to isolate to that vs. Jenkins if possible. |
It seems like something is wrong with the dockerized build. |
You are right @ixdy! |
Ah, I think I know what's wrong. You need to update |
b77c408
to
aa4cdac
Compare
Awesome, thanks! Have updated the PR. |
LGTM assuming everything builds this time :) |
GCE e2e build/test failed for commit aa4cdac. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
GCE e2e build/test passed for commit aa4cdac. |
Not sure why. I have retried 3 times, and I dont see that error on any other PR. So looks like it is caused by this change. |
Automatic merge from submit-queue |
oops. I didnt know that e2e-not-required ignores travis as well. |
@nikhiljindal if https://travis-ci.org/kubernetes/kubernetes/builds/124875718 fails, please revert. |
It failed. |
I'm not sure it's your PR. I think Travis is just busted. |
https://travis-ci.org/kubernetes/kubernetes/builds/124842648 and https://travis-ci.org/kubernetes/kubernetes/builds/124875707 also failed before your PR merged. |
federation/cmd/federated-apiserver was added in #23509
cc @jianhuiz