Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hack/build-go to build federation/cmd/federated-apiserver as well #24574

Merged

Conversation

nikhiljindal
Copy link
Contributor

federation/cmd/federated-apiserver was added in #23509

cc @jianhuiz

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 20, 2016
@nikhiljindal nikhiljindal added e2e-not-required release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 20, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 21, 2016

GCE e2e build/test failed for commit 1c214325f2b21485b3ab15a4f1469e86269283b6.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@nikhiljindal nikhiljindal force-pushed the buildFederatedServer branch from 1c21432 to b77c408 Compare April 21, 2016 00:31
@k8s-bot
Copy link

k8s-bot commented Apr 21, 2016

GCE e2e build/test failed for commit b77c4086eb8732e220e54c4f3084b7e99de452dd.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@nikhiljindal
Copy link
Contributor Author

I dont know why it cant find k8s.io/kubernetes/federation/cmd/federated-apiserver on jenkins.
hack/build-go.sh works fine locally.

@ixdy Any idea? Is that something to do with the way we have setup jenkins

@ixdy
Copy link
Member

ixdy commented Apr 21, 2016

@nikhiljindal does make quick-release work locally? It might be an issue with the dockerized crossbuild, since the unit/integration build worked without issue.

@ixdy
Copy link
Member

ixdy commented Apr 21, 2016

I don't understand why crossbuild would fail, but it'd help to isolate to that vs. Jenkins if possible.

@ixdy ixdy closed this Apr 21, 2016
@ixdy ixdy reopened this Apr 21, 2016
@luxas
Copy link
Member

luxas commented Apr 21, 2016

It seems like something is wrong with the dockerized build.
It fails on amd64 with the error can't find package.
Maybe it's some import statement that is wrong?

@nikhiljindal
Copy link
Contributor Author

You are right @ixdy!
make quick-release fails locally. So it is related to dockerized crossbuild. I would never have guessed that :)

@ixdy
Copy link
Member

ixdy commented Apr 21, 2016

Ah, I think I know what's wrong. You need to update kube::build::source_targets in build/common.sh.

@nikhiljindal nikhiljindal force-pushed the buildFederatedServer branch from b77c408 to aa4cdac Compare April 21, 2016 19:39
@nikhiljindal
Copy link
Contributor Author

nikhiljindal commented Apr 21, 2016

Awesome, thanks!
make quick-release passes locally now with that change.

Have updated the PR.
Hopefully Jenkins will get happy as well.

@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2016
@ixdy
Copy link
Member

ixdy commented Apr 21, 2016

LGTM assuming everything builds this time :)

@k8s-bot
Copy link

k8s-bot commented Apr 21, 2016

GCE e2e build/test failed for commit aa4cdac.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@nikhiljindal
Copy link
Contributor Author

@k8s-bot e2e test this issue: #24619

@k8s-bot
Copy link

k8s-bot commented Apr 21, 2016

GCE e2e build/test passed for commit aa4cdac.

@nikhiljindal
Copy link
Contributor Author

hack/build-go keeps failing on travis with the following error:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

Not sure why. I have retried 3 times, and I dont see that error on any other PR. So looks like it is caused by this change.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e73606b into kubernetes:master Apr 21, 2016
@nikhiljindal
Copy link
Contributor Author

oops. I didnt know that e2e-not-required ignores travis as well.
cc @k8s-oncall happy to revert this if you see travis failures on head due to this PR.

@krousey
Copy link
Contributor

krousey commented Apr 21, 2016

nikhiljindal added a commit to nikhiljindal/kubernetes that referenced this pull request Apr 21, 2016
@nikhiljindal
Copy link
Contributor Author

It failed.
Reverting: #24632

@ixdy
Copy link
Member

ixdy commented Apr 21, 2016

I'm not sure it's your PR. I think Travis is just busted.

@ixdy
Copy link
Member

ixdy commented Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants