Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: More support for ap-northeast-2 region #24464

Merged
merged 2 commits into from
May 17, 2016
Merged

AWS: More support for ap-northeast-2 region #24464

merged 2 commits into from
May 17, 2016

Conversation

matthewrudy
Copy link
Contributor

@matthewrudy matthewrudy commented Apr 19, 2016 •
edited by mikedanese
Loading

Issue #24446

The new AWS region for Seoul, Korea (ap-northeast-2)
was launched in January 2016
https://aws.amazon.com/blogs/aws/now-open-aws-asia-pacific-seoul-region/

But it requires a few changes.

To test:

export KUBERNETES_PROVIDER=aws
export KUBE_AWS_ZONE=ap-northeast-2a
export MASTER_SIZE=t2.medium
export NODE_SIZE=t2.medium
export NUM_NODES=4
cluster/kube-up.sh

I assigned the AMIs by checking the specific version used from ap-northeast-1,
and finding the same image with the same datestamp.

This change is Reviewable

@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@matthewrudy
Copy link
Contributor Author

ok to test

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Apr 19, 2016
@matthewrudy matthewrudy mentioned this pull request Apr 19, 2016
Closed
@matthewrudy matthewrudy force-pushed the aws-ap-northeast2 branch from 3aaad7d to 703a833 Compare May 5, 2016 11:16
@k8s-github-robot k8s-github-robot assigned ghost and eparis and unassigned eparis and ghost May 6, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2016
@eparis eparis assigned justinsb and unassigned eparis May 9, 2016
justinsb
justinsb reviewed May 10, 2016
View reviewed changes
cluster/aws/util.sh
@@ -360,6 +360,10 @@ function detect-trusty-image () {
AWS_IMAGE=ami-93876e93
;;

ap-northeast-2)
AWS_IMAGE=ami-62ac620c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I verified this ID against https://cloud-images.ubuntu.com/locator/

@justinsb
Copy link
Member

This looks good, except I don't think you updated your godeps correctly (and it needs a rebase). I would expect to see an update on Godeps.json, if the Godeps workspace files had changed. (But Godeps never ceases to surprise me, so I could be wrong here!)

@matthewrudy
Copy link
Contributor Author

@justinsb I'll rebase and fix the godeps later today,
thanks.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2016
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2016
@matthewrudy matthewrudy force-pushed the aws-ap-northeast2 branch 2 times, most recently from 0784ef5 to 23f51a5 Compare May 10, 2016 16:15
@matthewrudy
Copy link
Contributor Author

This is good to go @justinsb

To make the smallest possible change,
I only updated aws-sdk-go to 1.0.8
(the latest version is now 1.1.24)

I issued a separate PR to update to 1.1.24
#25411

@justinsb justinsb changed the title Add configuration for AWS ap-northeast-2 region AWS: More support for AWS ap-northeast-2 region May 10, 2016
@justinsb justinsb changed the title AWS: More support for AWS ap-northeast-2 region AWS: More support for ap-northeast-2 region May 10, 2016
@justinsb justinsb added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels May 10, 2016
@justinsb
Copy link
Member

ok to test

(lgtm though :-) )

@k8s-github-robot k8s-github-robot added needs-ok-to-merge needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 10, 2016
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2016
@matthewrudy
Copy link
Contributor Author

I rebased, and had to redo the godeps again after they were updated to the latest version.

@k8s-bot
Copy link

k8s-bot commented May 13, 2016

GCE e2e build/test passed for commit 895e444.

@justinsb justinsb added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7c1d37b into kubernetes:master May 17, 2016
@matthewrudy
Copy link
Contributor Author

Great.
thanks @justinsb @wojtek-t!

Look forward to deploying to AWS KR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matthewrudy @k8s-bot @justinsb @k8s-github-robot @googlebot @eparis @wojtek-t