Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Add support for ap-northeast-2 region (Seoul) #24457

Merged
merged 1 commit into from
May 2, 2016

Conversation

leokhoa
Copy link

@leokhoa leokhoa commented Apr 19, 2016

This PR does:

  • Support AWS Seoul region: ap-northeast-2.
    Currently, I can not setup Kubernetes on AWS Seoul.
    Error Messages:

ip-10-0-0-50 core # docker logs 0697db
I0419 07:57:44.569174 1 aws.go:466] Zone not specified in configuration file; querying AWS metadata service
F0419 07:57:44.570380 1 controllermanager.go:279] Cloud provider could not be initialized: could not init cloud provider "aws": not a valid AWS zone (unknown region): ap-northeast-2a

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@leokhoa
Copy link
Author

leokhoa commented Apr 19, 2016

I've signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 19, 2016
@leokhoa
Copy link
Author

leokhoa commented Apr 19, 2016

OMG, My change has no relation to guestbook!!!!!!!!!

@googlebot
Copy link

CLAs look good, thanks!

@leokhoa
Copy link
Author

leokhoa commented Apr 20, 2016

So slow response even with this simple issue :(

@justinsb
Copy link
Member

ok to test

@justinsb
Copy link
Member

I do wonder why we're checking against this list at all, when we get the zone from the metadata service. It looks like it just dates back to the original code AWS provider PR.

But LGTM

@justinsb justinsb added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2016
@k8s-github-robot k8s-github-robot added needs-ok-to-merge and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 20, 2016
@justinsb justinsb changed the title Kubernetes and AWS Seoul region AWS: Add support for ap-northeast-2 region (Seoul) Apr 29, 2016
@justinsb justinsb added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Apr 29, 2016
@k8s-bot
Copy link

k8s-bot commented May 1, 2016

GCE e2e build/test passed for commit ce771ef.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 2, 2016

GCE e2e build/test passed for commit ce771ef.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9289907 into kubernetes:master May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants