-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golint fixes for AWS cloudprovider #24385
Conversation
cc @justinsb |
Ping? It's large, but mostly cosmetic fixes. |
Sorry for the delay. I propose letting some of the other PRs merge, as this will likely break a lot of PRs, and they bring functional changes. It's my fault for letting the backlog build up. But then hopefully once they have merged there will be a relatively simple rebase needed only... |
Yeah, it makes sense. It might be also just easier to redo this from scratch. |
Marking this 1.4 - hopefully we can do this & other likely-to-cause-merge-conflict things early in 1.4. |
GCE e2e build/test failed for commit 0089a1d. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
GCE e2e build/test passed for commit cde85acb381662ca0f127169fc964efb4e558943. |
LGTM - thanks for fixing all of these! |
GCE e2e build/test passed for commit 8db551f. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 8db551f. |
Automatic merge from submit-queue |
…ck-of-#24385-kubernetes#29485-upstream-release-1.3 Automated cherry pick of kubernetes#24385 kubernetes#29485 upstream release 1.3
Among other things, golint doesn't like receivers that are inconsistently named or called "self". Or structs named aws.AWSservices, aws.AWSCloud, etc.