Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint fixes for AWS cloudprovider #24385

Merged
merged 1 commit into from
Jun 25, 2016
Merged

Conversation

therc
Copy link
Member

@therc therc commented Apr 17, 2016

Among other things, golint doesn't like receivers that are inconsistently named or called "self". Or structs named aws.AWSservices, aws.AWSCloud, etc.

@therc
Copy link
Member Author

therc commented Apr 17, 2016

cc @justinsb

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Apr 17, 2016
@therc
Copy link
Member Author

therc commented May 3, 2016

Ping? It's large, but mostly cosmetic fixes.

@justinsb
Copy link
Member

Sorry for the delay. I propose letting some of the other PRs merge, as this will likely break a lot of PRs, and they bring functional changes. It's my fault for letting the backlog build up.

But then hopefully once they have merged there will be a relatively simple rebase needed only...

@therc
Copy link
Member Author

therc commented May 10, 2016

Yeah, it makes sense. It might be also just easier to redo this from scratch.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2016
@justinsb justinsb added this to the v1.4 milestone Jun 9, 2016
@justinsb
Copy link
Member

justinsb commented Jun 9, 2016

Marking this 1.4 - hopefully we can do this & other likely-to-cause-merge-conflict things early in 1.4.

@k8s-bot
Copy link

k8s-bot commented Jun 23, 2016

GCE e2e build/test failed for commit 0089a1d.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test passed for commit cde85acb381662ca0f127169fc964efb4e558943.

@justinsb justinsb added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 24, 2016
@justinsb
Copy link
Member

LGTM - thanks for fixing all of these!

@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test passed for commit 8db551f.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 25, 2016

GCE e2e build/test passed for commit 8db551f.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2d35871 into kubernetes:master Jun 25, 2016
@therc therc deleted the fixes branch July 18, 2016 21:08
fabioy added a commit that referenced this pull request Jul 26, 2016
#29485-upstream-release-1.3

Automated cherry pick of #24385 #29485 upstream release 1.3
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…ck-of-#24385-kubernetes#29485-upstream-release-1.3

Automated cherry pick of kubernetes#24385 kubernetes#29485 upstream release 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants