-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote Pod Hostname & Subdomain to fields (were annotations) #24362
Promote Pod Hostname & Subdomain to fields (were annotations) #24362
Conversation
@@ -1225,6 +1225,10 @@ type PodSpec struct { | |||
// If specified, these secrets will be passed to individual puller implementations for them to use. For example, | |||
// in the case of docker, only DockerConfig type secrets are honored. | |||
ImagePullSecrets []LocalObjectReference `json:"imagePullSecrets,omitempty"` | |||
// Specifies the hostname of the Pod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. If not provided the pod's hostname will be set to a system-defined value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
64f199e
to
ba2a286
Compare
Re-titleing for release note |
@@ -47,7 +47,7 @@ spec: | |||
- name: etcd-storage | |||
mountPath: /var/etcd/data | |||
- name: kube2sky | |||
image: gcr.io/google_containers/kube2sky:1.14 | |||
image: artfulcoder/kube2sky-amd64:1.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget this
Also add a TODO at the definitions of the old annotations to remove them after v1.3 is released. |
Mostly pretty minor issues. Yay! |
We need corresponding docs on this. Both the DNS related docs and the pod-related docs. |
0b5eb83
to
e85f1fc
Compare
2fa9df3
to
5e05bc6
Compare
5e05bc6
to
05a58f3
Compare
@ArtfulCoder sorry if this is in the docs, I couldn't find it. The docs talk about a hostname |
05a58f3
to
c14c444
Compare
c14c444
to
8a3ed48
Compare
@ArtfulCoder |
@ArtfulCoder |
Great point - docs pls.
|
GCE e2e build/test passed for commit 8a3ed48. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 8a3ed48. |
Automatic merge from submit-queue |
@ArtfulCoder @thockin I didn't find any mention to the case when the number of replicas of a pod >1 in the code that got merged. I expected it somewhere in Are the docs coming in a follow up? Could you please share a link? Thanks! |
@rhcarvalho , for the case of replicas of a pod > 1, we are planning to introduce petsets, that will have some form of templatization for hostname field. |
@ArtfulCoder thanks for the reply. Currently, is it an error to specify a I'm following the PetSets PR (#18016), though I thought that was focused on persistent volumes. I'd like to have both scalable persistent storage and pod addressability by hostname to support MongoDB replica sets with persistent storage. |
@rhcarvalho If multiple pods have the same hostname, it is not an error. |
Deprecating the podHostName, subdomain and PodHostnames annotations and created corresponding new fields for them on PodSpec and Endpoints types.
Annotation doc: #22564
Annotation code: #20688