Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting the Host header in a httpGet probe #24292

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Allow setting the Host header in a httpGet probe #24292

merged 1 commit into from
Apr 20, 2016

Conversation

errm
Copy link
Contributor

@errm errm commented Apr 14, 2016

Fixes #24288

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Apr 14, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Apr 14, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Apr 14, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@errm
Copy link
Contributor Author

errm commented Apr 14, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Apr 14, 2016
@lavalamp lavalamp assigned lavalamp and unassigned brendandburns Apr 15, 2016
@lavalamp
Copy link
Member

LGTM, thanks.

@lavalamp lavalamp added this to the v1.2 milestone Apr 15, 2016
@lavalamp lavalamp removed this from the v1.2 milestone Apr 15, 2016
@lavalamp
Copy link
Member

I kicked travis, it's not clear why it failed.

@lavalamp lavalamp added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge release-note-none Denotes a PR that doesn't merit a release note. labels Apr 15, 2016
@lavalamp
Copy link
Member

ok to test

@errm errm force-pushed the fix-http-get-host-header branch from b20bb18 to 55b1ae8 Compare April 15, 2016 01:00
@errm
Copy link
Contributor Author

errm commented Apr 15, 2016

Rebased on master ...

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 15, 2016

GCE e2e build/test passed for commit b20bb18830c306915edd0db5519e81d44c5879d3.

@lavalamp lavalamp removed the release-note-none Denotes a PR that doesn't merit a release note. label Apr 18, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@lavalamp lavalamp added this to the v1.2 milestone Apr 18, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test passed for commit 55b1ae8.

@roberthbailey roberthbailey added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 19, 2016
@roberthbailey
Copy link
Contributor

I've labeled this P1 to try and get it merged into the master branch today so that it can be cherry picked.

@lavalamp lavalamp added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 19, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test passed for commit 55b1ae8.

@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test failed for commit 55b1ae8.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@errm
Copy link
Contributor Author

errm commented Apr 19, 2016

Looks like this is related to #19997, can someone request a retest please?

@bprashanth
Copy link
Contributor

@k8s-bot test this github issue: #19997

@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test passed for commit 55b1ae8.

@k8s-bot
Copy link

k8s-bot commented Apr 20, 2016

GCE e2e build/test passed for commit 55b1ae8.

@k8s-bot
Copy link

k8s-bot commented Apr 20, 2016

GCE e2e build/test passed for commit 55b1ae8.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Apr 20, 2016

GCE e2e build/test passed for commit 55b1ae8.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e8bd081 into kubernetes:master Apr 20, 2016
@zmerlynn zmerlynn added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 20, 2016
@zmerlynn
Copy link
Member

zmerlynn commented Apr 20, 2016 •
edited
Loading

@errm: Cherrypick approved. We're trying to get a 1.2.3 out the door soon, so please create a cherrypick PR tomorrow if possible. (If not, I may do it.)

@errm errm mentioned this pull request Apr 20, 2016
Merged
@errm
Copy link
Contributor Author

errm commented Apr 20, 2016

@zmerlynn ok cherrypick pr created . . .

@zmerlynn
Copy link
Member

@errm: Thanks!

zmerlynn added a commit that referenced this pull request Apr 20, 2016
@zmerlynn
Merge pull request #24522 from errm/automated-cherry-pick-of-#24292-u…
c19da0b 
…pstream-release-1.2

Automated cherry pick of #24292
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@zmerlynn
Merge pull request kubernetes#24522 from errm/automated-cherry-pick-o…
a6dfbe4 
…f-#24292-upstream-release-1.2

Automated cherry pick of kubernetes#24292
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@zmerlynn
Merge pull request kubernetes#24522 from errm/automated-cherry-pick-o…
7edb618 
…f-#24292-upstream-release-1.2

Automated cherry pick of kubernetes#24292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.