Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: fix error checking in kubelet stats #24205

Merged
merged 1 commit into from
Apr 13, 2016
Merged

e2e: fix error checking in kubelet stats #24205

merged 1 commit into from
Apr 13, 2016
+1 −1

Conversation

yujuhong
Copy link
Contributor

No description provided.

@yujuhong yujuhong added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 13, 2016
@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2016
@dchen1107
Copy link
Member

LGTM. :-)

@yujuhong
Copy link
Contributor Author

Thanks! This fixes the gce-serial suite (not a submit queue blocker) and should probably be merged sooner than later. @k8s-oncall

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot
Copy link

Removing LGTM because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-none", or "release-note-action-required"
Please see: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 13, 2016
@yujuhong yujuhong added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Apr 13, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 13, 2016

GCE e2e build/test passed for commit c6a2611.

@lavalamp
Copy link
Member

Build-cop merge.

@lavalamp lavalamp merged commit 97acf8c into kubernetes:master Apr 13, 2016
@lavalamp
Copy link
Member

Does this really need a release note?

@yujuhong
Copy link
Contributor Author

Does this really need a release note?

It needs to be cherry-picked to 1.2 with #24003, unfortunately.

This was referenced Apr 13, 2016
Closed
Merged
@roberthbailey roberthbailey added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 14, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@lavalamp lavalamp added this to the v1.2 milestone Apr 14, 2016
roberthbailey added a commit that referenced this pull request Apr 19, 2016
@roberthbailey
Merge pull request #24227 from yujuhong/automated-cherry-pick-of-#24015-
15f1165 
#24003-#24205-upstream-release-1.2

Automated cherry pick of #24015 #24003 #24205
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@yujuhong yujuhong deleted the fix_stats branch April 22, 2016 17:35
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@roberthbailey
Merge pull request kubernetes#24227 from yujuhong/automated-cherry-pi…
e5a7ab6 
…ck-of-#24015-kubernetes#24003-kubernetes#24205-upstream-release-1.2

Automated cherry pick of kubernetes#24015 kubernetes#24003 kubernetes#24205
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@roberthbailey
Merge pull request kubernetes#24227 from yujuhong/automated-cherry-pi…
7e85f8e 
…ck-of-#24015-kubernetes#24003-kubernetes#24205-upstream-release-1.2

Automated cherry pick of kubernetes#24015 kubernetes#24003 kubernetes#24205
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Nov 27, 2019
@k8s-publishing-bot
Merge pull request kubernetes#24205 from sttts/sttts-restore-dropped-…
2a65f18 
…upstreams-standa

Bug 1776351: Restore UPSTREAM:<carry>: apiserver crd validation: remove tls1.3 and modern profile

Origin-commit: 82e1b2f2df931f310b261d53f508057493e7d208
p0lyn0mial pushed a commit to p0lyn0mial/kubernetes that referenced this pull request Dec 20, 2019
@openshift-merge-robot
Merge pull request kubernetes#24205 from sttts/sttts-restore-dropped-…
8ee7011 
…upstreams-standa

Bug 1776351: Restore UPSTREAM:<carry>: apiserver crd validation: remove tls1.3 and modern profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
9 participants
@yujuhong @dchen1107 @k8s-github-robot @k8s-bot @lavalamp @k8s-cherrypick-bot @k8s-teamcity-mesosphere @googlebot @roberthbailey