Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterUpgrade tests #24150

Merged
merged 1 commit into from
Apr 13, 2016
Merged

Add ClusterUpgrade tests #24150

merged 1 commit into from
Apr 13, 2016

Conversation

ikehz
Copy link
Contributor

@ikehz ikehz commented Apr 12, 2016

This is a manual cherrypick of half of #22962.

@eparis, @bgrant0607, how do you all want to do this?

cc @spxtr as reviewer of #22962.

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 12, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Apr 12, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 12, 2016

GCE e2e build/test passed for commit e314e61.

@eparis eparis added this to the v1.2 milestone Apr 12, 2016
@eparis eparis assigned roberthbailey and unassigned bgrant0607 Apr 12, 2016
@eparis
Copy link
Contributor

eparis commented Apr 12, 2016

re-assigning to @roberthbailey since he owns 1.2 now. I added both the 1.2 milestone and the cp-candidate label to THIS PR. I'll leave it up to him to figure out exactly how he wants to handle it.

@roberthbailey
Copy link
Contributor

@ihmccreery It would be easier if you'd split the original PR into 2 PRs (you split it into two commits but the cherry pick tool works on PRs rather than commits).

@roberthbailey roberthbailey added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Apr 13, 2016
@roberthbailey
Copy link
Contributor

I think I've added the right labels for this to get merged into the release branch. We'll see if I've appeased the merge bot.

@eparis
Copy link
Contributor

eparis commented Apr 13, 2016

The bot won't touch it because jenkins unit tests failed :-( but the labels look good!

@zmerlynn
Copy link
Member

Yeah, and I haven't found an appropriate flake for this one.

@zmerlynn zmerlynn mentioned this pull request Apr 13, 2016
Closed
@zmerlynn
Copy link
Member

@k8s-bot unit test this, issue #24207.

@ikehz
Copy link
Contributor Author

ikehz commented Apr 13, 2016

@ihmccreery It would be easier if you'd split the original PR into 2 PRs (you split it into two commits but the cherry pick tool works on PRs rather than commits).

Ack.

@lavalamp lavalamp merged commit 59416a7 into kubernetes:release-1.2 Apr 13, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@ikehz
Copy link
Contributor Author

ikehz commented Apr 18, 2016

@roberthbailey Why did you add release-note? I disagree that this deserves a release note.

@ikehz ikehz mentioned this pull request Apr 18, 2016
Merged
@roberthbailey
Copy link
Contributor

All cherry picks require a release note.

k8s-github-robot pushed a commit that referenced this pull request Apr 20, 2016
Merge pull request #24428 from ihmccreery/report-prefix-1.2
b049b52 
Automatic merge from submit-queue

Add configuration for splitting upgrade jobs instead of using Jenkins steps

This is a manual cherrypick of another part of #22962 (different from #24150).  This properly propagates `E2E_REPORT_PREFIX`, since the files changed here are versioned differently from `e2e-runner.go`.

cc @roberthbailey @zmerlynn as owners of v1.2 branch?
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@lavalamp
Merge pull request kubernetes#24150 from ihmccreery/split-upgrade-job…
d295983 
…s-1.2

Add ClusterUpgrade tests
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#24428 from ihmccreery/report-prefix-1.2
7d2d7ff 
Automatic merge from submit-queue

Add configuration for splitting upgrade jobs instead of using Jenkins steps

This is a manual cherrypick of another part of kubernetes#22962 (different from kubernetes#24150).  This properly propagates `E2E_REPORT_PREFIX`, since the files changed here are versioned differently from `e2e-runner.go`.

cc @roberthbailey @zmerlynn as owners of v1.2 branch?
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@lavalamp
Merge pull request kubernetes#24150 from ihmccreery/split-upgrade-job…
45f562c 
…s-1.2

Add ClusterUpgrade tests
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
Merge pull request kubernetes#24428 from ihmccreery/report-prefix-1.2
3dee08e 
Automatic merge from submit-queue

Add configuration for splitting upgrade jobs instead of using Jenkins steps

This is a manual cherrypick of another part of kubernetes#22962 (different from kubernetes#24150).  This properly propagates `E2E_REPORT_PREFIX`, since the files changed here are versioned differently from `e2e-runner.go`.

cc @roberthbailey @zmerlynn as owners of v1.2 branch?
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Nov 19, 2019
@k8s-publishing-bot
Merge pull request kubernetes#24150 from deads2k/dynamic-cert-pick-01
6649eb0 
dynamic certs and cluster auth

Origin-commit: ff958cab9d36efedb8f9c0876c36c47163c9734c
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Dec 9, 2019
@k8s-publishing-bot
Merge pull request kubernetes#24150 from deads2k/dynamic-cert-pick-01
61c9822 
dynamic certs and cluster auth

Origin-commit: ff958cab9d36efedb8f9c0876c36c47163c9734c
p0lyn0mial pushed a commit to p0lyn0mial/kubernetes that referenced this pull request Dec 20, 2019
@openshift-merge-robot
Merge pull request kubernetes#24150 from deads2k/dynamic-cert-pick-01
23d286c 
dynamic certs and cluster auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
area/test area/upgrade cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.