Fix PullImage and add corresponding node e2e test #24126
Merged
+70
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
added
kind/bug
k8s-github-robot
added
size/L
Random-Liu
added
release-note-none
Random-Liu
force-pushed
the
fix-pull-image
branch
from
1fb331d to
8450b03
Compare
|
GCE e2e build/test passed for commit 1fb331df5dad99bd12cde747f749a25ec65dbe7f. |
|
GCE e2e build/test passed for commit 8450b039a97b6f4f6eef4341e790df2090c4a61d. |
| } | ||
| }) | ||
| }) | ||
| Context("when testing image that does not exist", func() { | ||
| var invalidImage ConformanceImage | ||
| var invalidImageTag string | ||
| It("it should not pull successfully [Conformance]", func() { |
There was a problem hiding this comment.
Remove "it":
It("should not pull
|
Looks good overall with some nits. |
Random-Liu
force-pushed
the
fix-pull-image
branch
from
8450b03 to
2b9f6be
Compare
|
@yujuhong Addressed comments. Thanks for reviewing! :) |
yujuhong
added
the
lgtm
|
GCE e2e build/test passed for commit 2b9f6be. |
|
GCE e2e build/test passed for commit 2b9f6be. |
|
GCE e2e build/test passed for commit 2b9f6be. |
|
GCE e2e build/test passed for commit 2b9f6be. |
|
GCE e2e build/test passed for commit 2b9f6be. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 2b9f6be. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24101. This is a bug introduced by #23506, since ref #23563.
The root cause of #24101 is described here.
This PR
ConformanceImage.Remove()andConformanceImage.Pull(). Because sometimes we may expect error to occur inPullImage()andRemoveImage(), but even that doesn't happen, thePresent()check will still return error and let the test pass.@yujuhong @freehan @liangchenye
Also /cc @resouer, because he is doing the image related functions refactoring.