Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #23929 #23463 #23934

Conversation

mikedanese
Copy link
Member

Cherry pick of #23929 #23463 on release-1.2.

ref #23013

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 6, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 6, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test passed for commit cab82bc.

@zmerlynn
Copy link
Member

zmerlynn commented Apr 6, 2016

I'm not taking this until the original PR has had a little soak time (like a hair's breath) on master.

@bprashanth bprashanth assigned davidopp and unassigned bprashanth Apr 6, 2016
@zmerlynn zmerlynn added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Apr 6, 2016
@zmerlynn
Copy link
Member

zmerlynn commented Apr 6, 2016

Base PR went through one run on GKE and one on GCE, good enough.

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2016
@zmerlynn zmerlynn assigned zmerlynn and unassigned davidopp Apr 6, 2016
@zmerlynn zmerlynn merged commit f026965 into kubernetes:release-1.2 Apr 6, 2016
@mikedanese mikedanese deleted the automated-cherry-pick-of-#23929-#23463-upstream-release-1.2 branch April 6, 2016 23:02
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Oct 14, 2019
Bug 1753500: UPSTREAM: 82503

Origin-commit: 5ecef400ee2b1368490ecb212163b3b1a4554e6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants