Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only include running and pending pods in daemonset should place calculation #23929

Merged
merged 1 commit into from
Apr 6, 2016
Merged

only include running and pending pods in daemonset should place calculation #23929

merged 1 commit into from
Apr 6, 2016

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese self-assigned this Apr 6, 2016
@mikedanese mikedanese mentioned this pull request Apr 6, 2016
Closed
@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test failed for commit efbd12be0b0b4b055e6eba0c1a78181f076968c2.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 6, 2016
@mikedanese mikedanese force-pushed the pending-running-ds branch 2 times, most recently from 32ef4b4 to 3bdbadc Compare April 6, 2016 19:21
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2016
@mikedanese mikedanese force-pushed the pending-running-ds branch from 3bdbadc to 2eacb00 Compare April 6, 2016 19:28
@mikedanese mikedanese removed their assignment Apr 6, 2016
@mikedanese mikedanese force-pushed the pending-running-ds branch from 2eacb00 to 1428429 Compare April 6, 2016 19:30
@davidopp
Copy link
Member

davidopp commented Apr 6, 2016

LGTM

@davidopp davidopp added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Apr 6, 2016
@mikedanese mikedanese added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 6, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2016
@mikedanese mikedanese added this to the v1.2 milestone Apr 6, 2016
@mikedanese mikedanese mentioned this pull request Apr 6, 2016
Merged
@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test failed for commit 32ef4b4b140f3350a4f17dd850c8556a815e5707.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test passed for commit 3bdbadc71be78031768fc3de84e06d85e2745500.

@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test passed for commit 1428429.

@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test passed for commit 2eacb00f1d1a056badde1270f87867887694a6f4.

@zmerlynn
Copy link
Member

zmerlynn commented Apr 6, 2016

@k8s-oncall: Manual merge, please. I'd like this on master for a little while before we cherrypick.

@saad-ali saad-ali merged commit c9b6e89 into kubernetes:master Apr 6, 2016
@mikedanese mikedanese deleted the pending-running-ds branch April 6, 2016 21:43
@zmerlynn zmerlynn added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 6, 2016
zmerlynn added a commit that referenced this pull request Apr 6, 2016
@zmerlynn
Merge pull request #23934 from mikedanese/automated-cherry-pick-of-#2…
f026965 
…3929-#23463-upstream-release-1.2

Automated cherry pick of #23929 #23463
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@zmerlynn
Merge pull request kubernetes#23934 from mikedanese/automated-cherry-…
29263bb 
…pick-of-#23929-kubernetes#23463-upstream-release-1.2

Automated cherry pick of kubernetes#23929 kubernetes#23463
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@zmerlynn
Merge pull request kubernetes#23934 from mikedanese/automated-cherry-…
5625094 
…pick-of-#23929-kubernetes#23463-upstream-release-1.2

Automated cherry pick of kubernetes#23929 kubernetes#23463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
10 participants
@mikedanese @k8s-bot @k8s-github-robot @davidopp @zmerlynn @k8s-cherrypick-bot @k8s-teamcity-mesosphere @googlebot @bgrant0607 @saad-ali