Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #23843 #23901

Merged
merged 1 commit into from
Apr 6, 2016
Merged

Automated cherry pick of #23843 #23901

merged 1 commit into from
Apr 6, 2016

Conversation

cjcullen
Copy link
Member

@cjcullen cjcullen commented Apr 6, 2016

Cherry pick of #23843 on release-1.2.

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 6, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 6, 2016
@thockin thockin assigned a-robinson and unassigned thockin Apr 6, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test passed for commit 1ad5373.

@a-robinson a-robinson added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2016
@k8s-github-robot
Copy link

Removing LGTM because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-none", or "release-note-action-required"
Please see: https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/release-notes.md

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2016
@cjcullen cjcullen added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 6, 2016
@k8s-github-robot k8s-github-robot added this to the v1.2 milestone Apr 6, 2016
@k8s-github-robot k8s-github-robot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 6, 2016
@zmerlynn zmerlynn added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Apr 6, 2016
@zmerlynn zmerlynn assigned zmerlynn and unassigned a-robinson Apr 6, 2016
@zmerlynn zmerlynn merged commit 8099c6a into kubernetes:release-1.2 Apr 6, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@zmerlynn
Merge pull request kubernetes#23901 from cjcullen/automated-cherry-pi…
c819e1f 
…ck-of-#23843-upstream-release-1.2

Automated cherry pick of kubernetes#23843
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@zmerlynn
Merge pull request kubernetes#23901 from cjcullen/automated-cherry-pi…
eb5efc4 
…ck-of-#23843-upstream-release-1.2

Automated cherry pick of kubernetes#23843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
8 participants
@cjcullen @k8s-github-robot @k8s-bot @k8s-teamcity-mesosphere @zmerlynn @googlebot @thockin @a-robinson