Move shell completion generation into 'kubectl completion' command #23801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/L
|
should any of the zsh glue stuff move into the cobra repo, for others? |
sttts
force-pushed
the
sttts-kubectl-completion-cmd
branch
from
664f416 to
93998cb
Compare
|
Very good question. I reimplement a number of missing functions that are not part of the zsh completion environment to make it work, of course only as far as necessary for kubectl. This is not really a "just-works" situation for other programs based on cobra, depending especially on custom functions. Let me check in detail. |
k8s-github-robot
added
kind/old-docs
size/XS
eparis
added
release-note
k8s-github-robot
added
the
needs-rebase
k8s-github-robot
assigned brendandburns and thockin and unassigned eparis and brendandburns
|
@kubernetes/kubectl |
|
@sttts are you going to rebase this? did we land all the pre-reqs? |
|
@eparis will rebase |
sttts
force-pushed
the
sttts-kubectl-completion-cmd
branch
from
93998cb to
715e5d3
Compare
k8s-github-robot
added
size/L
|
@ingvagabund @liggitt @deads2k please CC anyone else you know of who might get bitten by this.... |
eparis
added
the
lgtm
|
On Mon, May 9, 2016 at 2:53 PM, Kubernetes Bot notifications@github.com
|
|
Rebased. |
k8s-github-robot
removed
the
needs-rebase
k8s-github-robot
added
the
needs-rebase
sttts
force-pushed
the
sttts-kubectl-completion-cmd
branch
from
f208125 to
3020465
Compare
sttts
added
lgtm
k8s-github-robot
removed
the
needs-rebase
sttts
force-pushed
the
sttts-kubectl-completion-cmd
branch
from
3020465 to
9e25d9f
Compare
sttts
added
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 9e25d9f. |
|
Automatic merge from submit-queue |
|
Amen. |
4 tasks
xingzhou
added a commit
to xingzhou/official.kubernetes.github.io
that referenced
this pull request
Aug 25, 2016
We have moved the shell script into `kubectl completion` command in [kubernetes#23801](kubernetes/kubernetes#23801), updated the bash completion usage in the doc. Fixes kubernetes#1092
xingzhou
added a commit
to xingzhou/official.kubernetes.github.io
that referenced
this pull request
Aug 29, 2016
We have moved the shell script into `kubectl completion` command in [kubernetes#23801](kubernetes/kubernetes#23801), updated the bash completion usage in the doc. Fixes kubernetes#1092
xingzhou
added a commit
to xingzhou/official.kubernetes.github.io
that referenced
this pull request
Aug 30, 2016
We have moved the shell script into `kubectl completion` command in [kubernetes#23801](kubernetes/kubernetes#23801), updated the bash completion usage in the doc. Fixes kubernetes#1092
devin-donnelly
pushed a commit
to kubernetes/website
that referenced
this pull request
Aug 30, 2016
We have moved the shell script into `kubectl completion` command in [#23801](kubernetes/kubernetes#23801), updated the bash completion usage in the doc. Fixes #1092
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Sep 19, 2019
…ource-error-message Bug 1743675: validations: for negative PVC storage size don't report "must be >= 0" Origin-commit: 164fc5b8b6ff3a8f911bdf6c8ca94a7666de9e3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove static shell completion scripts from the repo and add
completioncommand to kubectl:or
This makes maintenance easier because no static scripts must be generated and committed anymore in the repo.
Moreover, kubectl is self-contained again for the user including the latest completion code. I am thinking about the use-case of updating kubectl via gcloud (or some package manager). The completion code is always in-sync, without the need to download a
contrib/completion/bash/kubectlfile from github.Opinions are welcome /cc @eparis @nak3
Fixes openshift/origin#5290
This change is