-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dashboard UI addon to v1.0.1 #23724
Update Dashboard UI addon to v1.0.1 #23724
Conversation
Labelling this PR as size/XS |
LGTM |
Can you add release notes: https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/release-notes.md ? |
Removing LGTM because the release note process has not been followed. |
GCE e2e build/test passed for commit a14e4c1984935e1d489fa58e896d3be95ac1c4e9. |
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
a14e4c1
to
1310e08
Compare
@bryk Added new entry to release notes in CHANGELOG.md. Is it okay? I'm not sure about its placement, because |
GCE e2e build/test passed for commit 1310e08849e3abcdd18d5fd37e93e8e9f55fb041. |
Please revert the changelog. All we need to do is add release-note label. |
@bryk Done. It wasn't so easy to understand how to proceed with it to me. Hopefully now it's okay. |
GCE e2e build/test passed for commit 7733a1c97daebd4cfd5cead6d5ea10614e424224. |
@bryk I can see, that one of the tests failed. I do not see any connection to changes made, could you take a look? |
@roberthbailey How can I rerun the "Jenkins GCE Node e2e" test? It looks flaky. |
@pwittrock recently added that test and said he'd keep an eye on it so let's just ping him and ask what he'd like to do. |
@bryk Should this be a cherry pick candidate? It looks like 1.0.1 fixed quite a few bugs. |
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
GCE e2e build/test passed for commit 7733a1c97daebd4cfd5cead6d5ea10614e424224. |
Yes. How do I do this? |
7733a1c
to
7250028
Compare
PR changed after LGTM, removing LGTM. |
Labelling this PR as size/S |
LGTM |
GCE e2e build/test passed for commit 7250028. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 7250028. |
Automatic merge from submit-queue |
…24-upstream-release-1.2 Automated cherry pick of #23724
@eparis: I might know what's going on, but we should chat on Slack at some point. |
The commit message was somehow mangled in the cherrypick PR. In this PR the commit seems to have sane line breaks. In the cherry-pick PR the commit message seems to be missing a line break... The heuristic to auto clear is based on git commit messages... |
…ck-of-#23724-upstream-release-1.2 Automated cherry pick of kubernetes#23724
…ck-of-#23724-upstream-release-1.2 Automated cherry pick of kubernetes#23724
Release details:
https://github.com/kubernetes/dashboard/releases/tag/v1.0.1
CC @bryk