Don't show Kubernetes username & password to console for heapster. #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @vishh |
|
@vishh let's talk about how heapster could use the same token authentication and authorization policies that we are working on for kubernetes. I want to get rid of user/pass. |
|
@erictune: Ok. |
|
Agreed with @erictune on using token instead of user/pass. But before we are reaching there, could we have this in as intermediate step? Without this, now user/pass is showed on console. We have some users complaining this before. |
|
LGTM |
erictune
added a commit
that referenced
this pull request
Nov 14, 2014
Don't show Kubernetes username & password to console for heapster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.