Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #23662 #23687

Conversation

ArtfulCoder
Copy link
Contributor

Cherry pick of #23662 on release-1.2.

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2016
@ArtfulCoder
Copy link
Contributor Author

@roberthbailey @cjcullen

@ArtfulCoder ArtfulCoder assigned bgrant0607 and unassigned davidopp Mar 31, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 31, 2016

GCE e2e build/test passed for commit 16fd1df.

@bgrant0607
Copy link
Member

LGTM

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 31, 2016
@bgrant0607 bgrant0607 added this to the v1.2 milestone Mar 31, 2016
@bgrant0607 bgrant0607 added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 31, 2016
@bgrant0607
Copy link
Member

Merging.

@bgrant0607 bgrant0607 merged commit 38b11ba into kubernetes:release-1.2 Mar 31, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…-pick-of-#23662-upstream-release-1.2

Automated cherry pick of kubernetes#23662
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…-pick-of-#23662-upstream-release-1.2

Automated cherry pick of kubernetes#23662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants