Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TerminationMessagePath #23658

Merged
merged 1 commit into from
Apr 9, 2016
Merged

Fix TerminationMessagePath #23658

merged 1 commit into from
Apr 9, 2016

Conversation

Random-Liu
Copy link
Member

Fixes #23639.

Use Mounts instead of Volumes to get the TerminationMessageLog. I've tried it and it works now.

@Random-Liu Random-Liu added kind/bug Categorizes issue or PR as related to a bug. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 30, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2016
@Random-Liu Random-Liu assigned yujuhong and unassigned dchen1107 Mar 31, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 31, 2016

GCE e2e build/test passed for commit 5dbac3a.

@yujuhong
Copy link
Contributor

Thanks for the fix! We should add an (node) e2e test for termination message path.

@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2016
@Random-Liu Random-Liu mentioned this pull request Mar 31, 2016
Closed
3 tasks
@eparis eparis added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 31, 2016
@Random-Liu
Copy link
Member Author

Close this one because it is included in #23699.

@Random-Liu Random-Liu closed this Mar 31, 2016
@Random-Liu
Copy link
Member Author

@yujuhong Reopen this for better bug tracking.

@Random-Liu Random-Liu reopened this Apr 1, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 1, 2016

GCE e2e build/test passed for commit 5dbac3a.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Apr 3, 2016

GCE e2e build/test passed for commit 5dbac3a.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Apr 5, 2016

GCE e2e build/test passed for commit 5dbac3a.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@yujuhong
Copy link
Contributor

yujuhong commented Apr 7, 2016

@dchen1107, FYI in case you wasn't aware of this issue: TerminationMessagePath has been broken since we upgraded to docker 1.8.3. This PR fixes it.

@Random-Liu Random-Liu mentioned this pull request Apr 7, 2016
Merged
@k8s-bot
Copy link

k8s-bot commented Apr 7, 2016

GCE e2e build/test failed for commit 5dbac3a.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@Random-Liu
Copy link
Member Author

@k8s-bot test this issue #23974

@k8s-bot
Copy link

k8s-bot commented Apr 7, 2016

GCE e2e build/test passed for commit 5dbac3a.

@j3ffml j3ffml merged commit 1a9cb97 into kubernetes:master Apr 9, 2016
@Random-Liu Random-Liu deleted the fix-termination-message-path branch April 9, 2016 04:09
@Random-Liu Random-Liu mentioned this pull request Apr 15, 2016
Closed
@yujuhong
Copy link
Contributor

I think we should patch 1.2 with this. @Random-Liu, could you do that?

@Random-Liu
Copy link
Member Author

@yujuhong Sure.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@Random-Liu Random-Liu added this to the v1.2 milestone Apr 15, 2016
@yujuhong yujuhong added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 15, 2016
@yujuhong
Copy link
Contributor

Cherrypick candidates need the release-note label.

@Random-Liu
Copy link
Member Author

Random-Liu commented Apr 15, 2016 •
edited
Loading

@yujuhong Looks like either release-note or release-note-none is ok?
Add an appropriate release-note-(!label-needed) label. https://github.com/kubernetes/kubernetes/blob/2912fcc3bae1b273abd949bf9d6010d8914ab549/docs/devel/cherry-picks.md#propose-a-cherry-pick

@yujuhong
Copy link
Contributor

I got that from @bgrant0607's comment, but I couldn't find it anymore.

Anyway, I think this is worthy of a note since it's a bug fix on a release branch.

@Random-Liu
Copy link
Member Author

@yujuhong OK. Thanks! :)

@roberthbailey roberthbailey added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 19, 2016
@roberthbailey
Copy link
Contributor

@Random-Liu Please create a cherry pick pull for this PR.

@Random-Liu
Copy link
Member Author

@roberthbailey Will do soon.

@Random-Liu Random-Liu mentioned this pull request Apr 19, 2016
Merged
zmerlynn added a commit that referenced this pull request Apr 20, 2016
@zmerlynn
Merge pull request #24504 from Random-Liu/automated-cherry-pick-of-#2…
812b3b7 
…3658-upstream-release-1.2

Automated cherry pick of #23658
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

k8s-github-robot pushed a commit that referenced this pull request Jun 20, 2016
Merge pull request #23969 from Random-Liu/add-termination-message-test
bd9ac8d 
Automatic merge from submit-queue

Node E2E: add termination message test

Based on #23658.

This PR:
1) Cleans up the `ConformanceContainer` a bit
2) Add termination message test

This test proves #23639, without #23658, the test could not pass.

@liangchenye @kubernetes/sig-node
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@zmerlynn
Merge pull request kubernetes#24504 from Random-Liu/automated-cherry-…
83c6780 
…pick-of-#23658-upstream-release-1.2

Automated cherry pick of kubernetes#23658
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@zmerlynn
Merge pull request kubernetes#24504 from Random-Liu/automated-cherry-…
48df94d 
…pick-of-#23658-upstream-release-1.2

Automated cherry pick of kubernetes#23658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yujuhong yujuhong

Labels
area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.