run kube-addon-manager in a static pod #23600
Merged
+92
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
the
size/XL
mikedanese
force-pushed
the
addon-manager
branch
3 times, most recently
from
4d443f4 to
6dda05e
Compare
k8s-github-robot
added
needs-rebase
mikedanese
force-pushed
the
addon-manager
branch
from
6dda05e to
c2b15a4
Compare
k8s-github-robot
added
size/L
mikedanese
force-pushed
the
addon-manager
branch
4 times, most recently
from
1f1d97f to
0eeb6b1
Compare
mikedanese
force-pushed
the
addon-manager
branch
from
0eeb6b1 to
8117c31
Compare
mikedanese
force-pushed
the
addon-manager
branch
from
8117c31 to
5dd175c
Compare
mikedanese
added
release-note-none
mikedanese
changed the title
I may send a PR for cross-building this image |
roberthbailey
added
the
lgtm
|
GCE e2e build/test passed for commit 3e1c0b5. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 3e1c0b5. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
May 10, 2016
Automatic merge from submit-queue GCI/Trusty: Fix the running of kube-addon-manager This PR fixes the issue that kube-addon-master (added in #23600) is not started. Without this fix, no kube-system pods can be running correctly. As a result, the GCI-based Jenkins testing k8s head has been down for a couple of days. The root cause is that we stopped to use namespace.yaml, but configure-helper.sh still tries to copy it. This PR also gets rid of /var/cache/kubernetes-install/kube_env.yaml, as it is not needed anymore after #24108. @mikedanese @roberthbailey @dchen1107 please review it. If possible please mark it as P1, as it blocks GCI-based Jenkins tests. cc/ @kubernetes/goog-image @fabioy FYI
This was referenced May 17, 2016
|
@mikedanese it looks like this commit broke addons support in contrib/ansible kubernetes-retired/contrib#1004 |
euank
added a commit
to euank/kubernetes
that referenced
this pull request
May 24, 2016
After kubernetes#23600 our previous kube-up was broken. This fixes it.
euank
added a commit
to coreos/kubernetes
that referenced
this pull request
May 25, 2016
After kubernetes#23600 our previous kube-up was broken. This fixes it.
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Aug 16, 2019
…nt-manager-tests Bug 1733581: Failing tests NoExecuteTaintManager Multiple Pods evicts pods Origin-commit: 2d1df54a8e1cded7ada239b2029655d4aa9155f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #23605 and #24108
Ref #23233