Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #23530 #23467 #23586

Merged
merged 2 commits into from
Mar 30, 2016
Merged

Automated cherry pick of #23530 #23467 #23586

merged 2 commits into from
Mar 30, 2016

Conversation

mikedanese
Copy link
Member

Cherry pick of #23530 #23467 on release-1.2.

@mikedanese mikedanese added this to the v1.2 milestone Mar 29, 2016
@mikedanese mikedanese assigned davidopp and bgrant0607 and unassigned davidopp Mar 29, 2016
@mikedanese
Copy link
Member Author

cc @davidopp @david-mcmahon

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 29, 2016

GCE e2e build/test passed for commit e33331c.

@bgrant0607
Copy link
Member

LGTM

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 29, 2016
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 29, 2016
@bgrant0607
Copy link
Member

Hmm. Not sure what's up with the bot. Merging.

@bgrant0607 bgrant0607 merged commit 99cdc06 into kubernetes:release-1.2 Mar 30, 2016
@bgrant0607 bgrant0607 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Mar 30, 2016
@liggitt liggitt mentioned this pull request Mar 31, 2016
Closed
85 tasks
@mikedanese mikedanese deleted the automated-cherry-pick-of-#23530-#23467-upstream-release-1.2 branch March 31, 2016 23:15
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@bgrant0607
Merge pull request kubernetes#23586 from mikedanese/automated-cherry-…
a6cf1e8 
…pick-of-#23530-kubernetes#23467-upstream-release-1.2

Automated cherry pick of kubernetes#23530 kubernetes#23467
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@bgrant0607
Merge pull request kubernetes#23586 from mikedanese/automated-cherry-…
07e7d7c 
…pick-of-#23530-kubernetes#23467-upstream-release-1.2

Automated cherry pick of kubernetes#23530 kubernetes#23467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@mikedanese @k8s-github-robot @k8s-bot @bgrant0607 @googlebot @davidopp