Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate that daemonsets don't have empty selectors on creation #23530

Merged
merged 1 commit into from
Mar 29, 2016
Merged

validate that daemonsets don't have empty selectors on creation #23530

merged 1 commit into from
Mar 29, 2016
+10 −0

Conversation

mikedanese
Copy link
Member

So appearently we don't validate this yet

ref #23218

@mikedanese mikedanese added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 27, 2016
@mikedanese mikedanese added this to the v1.2 milestone Mar 27, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 27, 2016

GCE e2e build/test passed for commit 3908e2e32484f399b7e09c718e12a99eb3e76b8e.

@k8s-bot
Copy link

k8s-bot commented Mar 27, 2016

GCE e2e build/test passed for commit e4bcbfb468fba0ac1edd2ec0bea7da5f0782c928.

@davidopp
Copy link
Member

Can you add a test?

@davidopp
Copy link
Member

(Oh and thanks for catching this!)

@k8s-github-robot k8s-github-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 28, 2016
@mikedanese
Copy link
Member Author

@davidopp added test PTAL

@k8s-bot
Copy link

k8s-bot commented Mar 28, 2016

GCE e2e build/test passed for commit 2eb4896.

@davidopp
Copy link
Member

LGTM

@davidopp davidopp added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate labels Mar 28, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 28, 2016

GCE e2e build/test passed for commit 2eb4896.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 28, 2016

GCE e2e build/test passed for commit 2eb4896.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 29, 2016

GCE e2e build/test passed for commit 2eb4896.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 29, 2016

GCE e2e build/test passed for commit 2eb4896.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 12b0a06 into kubernetes:master Mar 29, 2016
@mikedanese mikedanese deleted the validate-ds branch March 29, 2016 03:43
@mikedanese mikedanese mentioned this pull request Mar 29, 2016
Merged
@liggitt liggitt mentioned this pull request Mar 29, 2016
Closed
85 tasks
bgrant0607 added a commit that referenced this pull request Mar 30, 2016
@bgrant0607
Merge pull request #23586 from mikedanese/automated-cherry-pick-of-#2…
99cdc06 
…3530-#23467-upstream-release-1.2

Automated cherry pick of #23530 #23467
@bgrant0607 bgrant0607 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 30, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@bgrant0607
Merge pull request kubernetes#23586 from mikedanese/automated-cherry-…
a6cf1e8 
…pick-of-#23530-kubernetes#23467-upstream-release-1.2

Automated cherry pick of kubernetes#23530 kubernetes#23467
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@bgrant0607
Merge pull request kubernetes#23586 from mikedanese/automated-cherry-…
07e7d7c 
…pick-of-#23530-kubernetes#23467-upstream-release-1.2

Automated cherry pick of kubernetes#23530 kubernetes#23467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
9 participants
@mikedanese @k8s-github-robot @k8s-bot @davidopp @k8s-cherrypick-bot @r0mant @k8s-teamcity-mesosphere @googlebot @bgrant0607