Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove examples moved to docs site #23513

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Remove examples moved to docs site #23513

merged 1 commit into from
Jul 18, 2016
+6 −1,161

Conversation

erictune
Copy link
Member

@erictune erictune commented Mar 25, 2016 •
edited by mikedanese
Loading

Part of #23511
Left redirect in md files and deleted files intended for download.

This change is Reviewable

@erictune erictune mentioned this pull request Mar 25, 2016
Closed
@k8s-github-robot k8s-github-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 25, 2016
@bgrant0607
Copy link
Member

Thanks. We need to get examples tests working in the docs repo.
cc @kubernetes/docs @kubernetes/examples

bgrant0607
bgrant0607 reviewed Mar 25, 2016
View reviewed changes
examples/job/expansions/README.md
@@ -21,7 +22,7 @@ refer to the docs that go with that version.
<!-- TAG RELEASE_LINK, added by the munger automatically -->
<strong>
The latest release of this document can be found
[here](http://releases.k8s.io/release-1.2/examples/job/expansions/README.md).
[here](http://releases.k8s.io/release-1.2/docs/user-guide/jobs.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest http://kubernetes.io/docs/user-guide/jobs/

@erictune
Copy link
Member Author

All comments addressed

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 10, 2016
@zmerlynn
Copy link
Member

This was sitting in my PR queue but I didn't notice it because I subtracted needs-rebase for a while. Do you want to get it in soon?

@erictune
Copy link
Member Author

Rebased, PTAL

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2016
@zmerlynn
Copy link
Member

It's failing unit tests in k8s.io/kubernetes/examples, which seems real.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2016
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 7, 2016
@erictune
Remove examples moved to docs site
bbfda4b 
Part of kubernetes#23511
Left redirect in md files and deleted files intended for download.
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2016
@zmerlynn zmerlynn added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed release-note-label-needed labels Jul 18, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 18, 2016

GCE e2e build/test passed for commit bbfda4b.

@zmerlynn
Copy link
Member

I'm not clear why this isn't at the top of the SQ again (it was a bit ago), but trying to ensure it slips in before another rebase.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit d92f685 into kubernetes:master Jul 18, 2016
@erictune erictune deleted the foo branch August 8, 2017 18:17
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Jul 31, 2019
@k8s-publishing-bot
Merge pull request kubernetes#23513 from rphillips/backports/80657
0b3813e 
UPSTREAM: 80657: add UID to kubelet_container_log_filesystem_used_bytes metric

Origin-commit: 287f1c883767f3407ffdc7c4a3cc614241df4645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@erictune @bgrant0607 @zmerlynn @k8s-bot @k8s-github-robot @googlebot @johndmulhausen