Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

Labelling this PR as size/XXL

Am curious if you tried using the code as in https://github.com/kubernetes/kubernetes/blob/master/examples/apiserver/apiserver.go?

Ref #21190 (comment)

@nikhiljindal I'm aware of that piece of code, and I wouldn't mind starting a brand new ube-apiserver. I guess I didn't explain my self clearly, the problem is that ube-apiserver is meant to be compatible with kube-apiserver, which means in the end there has to be some kind of reuse/sync of these two apiservers. I prefer coping kube-apiserver for now is that I can focus on the api objects instead of getting distracted of all the details such as the options/configs of the apiserver it self.

ok thats reasonable. I can work on reducing the code duplication while you can work on ubernetes API objects.
Thanks for moving the code to federation directory.

ube-apiserver doesnt look like the right name.
Maybe rename to just apiserver since it is already under federation directory? federated-apiserver will be long.

@kubernetes/sig-api-machinery @kubernetes/sig-cluster-federation

@k8s-bot ok to test

GCE e2e build/test failed for commit 442ca923d63e1b4f8ef8b00caf529cb06d8aba19.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

Thanks @nikhiljindal.
I agree that federated-apiserver will be long, what about fed-apiserver, and fed-xxx for other components?
BTW, it appears that the kube-api had changed just yesterday, I'll merge those changes and update the PR.

GCE e2e build/test failed for commit 7ad455d1ad0f76a6948c16843afb5fe278053256.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

I would call it uber-apiserver personally. I prefer "federated-apiserver" to "fed-apiserver" (we use abbreviations very rarely).

If long name is not a concern than federated-apiserver seems best.

it was uber-apiserver in the very first PR however suggested to be changed to ube-apiserver because of kube ube consistency.
federated-apiserver seemed long to me personally because I find the long federated- prefix distracting (after all an apiserver it is) and slows me down when reading and looking for it.
however as long as you are all agreed to use federated-apiserver, I'll update the PR soon.

Since we call the other binaries kube-* I'm not morally opposed to
uber-*. But then, I'd probably rename kube-apiserver if it could.

Since we're voting on names :-) I'm generally more in favor of semantic rather than brand names in code, because it reduces cognitive overhead. So "federated..." in preference to "ubernetes..." or "...ube". Regarding the name length concern, it seems that in most cases this can be addressed by importing it as a shorter name (e.g. "fed") where desired.

So to cast my vote, I'm with Nikhil on "federated-apiserver". But I don't feel strongly enough about it to veto some other majority view.

Thanks for renaming to federated-apiserver.
LGTM.

GCE e2e build/test passed for commit ca72bba.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

GCE e2e build/test passed for commit ca72bba.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit ca72bba.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue